Skip to content

Commit

Permalink
GH-35712: [C++][CI] MacOS Disable ASSERT_DEATH in arrow-array-test (#…
Browse files Browse the repository at this point in the history
…35724)

### Rationale for this change

Disable ASSERT_DEATH in MacOS. According to #35712, it would making CI extremely slow.

### What changes are included in this PR?

Disable test in macos

### Are these changes tested?

no

### Are there any user-facing changes?

no

* Closes: #35712

Authored-by: mwish <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
  • Loading branch information
mapleFU authored May 23, 2023
1 parent f38943a commit ce095e4
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions cpp/src/arrow/array/array_dict_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1129,12 +1129,15 @@ TEST(TestDictionary, Validate) {
arr = std::make_shared<DictionaryArray>(dict_type, indices, MakeArray(invalid_data));
ASSERT_RAISES(Invalid, arr->ValidateFull());

#if !defined(__APPLE__)
// GH-35712: ASSERT_DEATH would make testing slow on MacOS.
ASSERT_DEATH(
{
std::shared_ptr<Array> null_dict_arr =
std::make_shared<DictionaryArray>(dict_type, indices, nullptr);
},
"");
#endif
}

TEST(TestDictionary, FromArrays) {
Expand Down

0 comments on commit ce095e4

Please sign in to comment.