Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [Docs][C++] Improve Input Shapes section of Compute doc #35720

Merged
merged 1 commit into from
May 23, 2023

Conversation

js8544
Copy link
Collaborator

@js8544 js8544 commented May 23, 2023

  1. The function that only takes arrays should be array_sort_indices, not sort_indices.
  2. IMO The word either implies that array_sort_indices also accepts chunked arrays but in fact it doesn't. So I changed either to particular input types.
  3. There are no mention of two dimensional data types, i.e. RecordBatch and Table, throughout the Input Shapes section, which I feel like is a miss. So I added sort_indices as an example for them.

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou kou changed the title MINOR: [C++] Improve Input Shapes section of Compute doc MINOR: [Docs][C++] Improve Input Shapes section of Compute doc May 23, 2023
@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels May 23, 2023
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @js8544 !

@pitrou pitrou merged commit 6d3d2fc into apache:main May 23, 2023
@ursabot
Copy link

ursabot commented May 30, 2023

Benchmark runs are scheduled for baseline = ce095e4 and contender = 6d3d2fc. 6d3d2fc is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Finished ⬇️0.3% ⬆️0.0%] test-mac-arm
[Finished ⬇️0.98% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.94% ⬆️0.03%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] 6d3d2fca ec2-t3-xlarge-us-east-2
[Finished] 6d3d2fca test-mac-arm
[Finished] 6d3d2fca ursa-i9-9960x
[Finished] 6d3d2fca ursa-thinkcentre-m75q
[Finished] ce095e46 ec2-t3-xlarge-us-east-2
[Finished] ce095e46 test-mac-arm
[Finished] ce095e46 ursa-i9-9960x
[Finished] ce095e46 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@ursabot
Copy link

ursabot commented May 31, 2023

['Python', 'R'] benchmarks have high level of regressions.
ursa-i9-9960x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants