-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17840: [Java] Disable flaky JaCoCo coverage check #14231
Conversation
@github-actions crossbow submit java-jars |
Revision: 63a87f5 Submitted crossbow builds: ursacomputing/crossbow @ actions-b04d06f201
|
The check doesn't add much value, and makes things flaky because whether a branch is covered or not can come down to chance based on where exactly an exception occurs.
63a87f5
to
9823720
Compare
@github-actions crossbow submit java-jars |
Revision: 9823720 Submitted crossbow builds: ursacomputing/crossbow @ actions-c3889846c2
|
What's the connection between JaCoCo and the JDK8 and JDK9+ profiles? |
We used to have to pass more options to Surefire to get JaCoCo to work, so we had to duplicate some of the test config (since JDK8/9+ require different Surefire options). Now that we're not using JaCoCo, we also don't need that config, so we can simplify it |
Makes sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Benchmark runs are scheduled for baseline = acd69f9 and contender = 9b4a181. 9b4a181 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
['Python', 'R'] benchmarks have high level of regressions. |
The check doesn't add much value, and makes things flaky because whether a branch is covered or not can come down to chance based on where exactly an exception occurs. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
The check doesn't add much value, and makes things flaky because whether a branch is covered or not can come down to chance based on where exactly an exception occurs.