-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARROW-17785: [Java] Suppress flakiness from gRPC in JDBC driver tests #14210
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
FYI @jduo if you have a better idea of the root cause here |
Benchmark runs are scheduled for baseline = bed6f8e and contender = dfdd0ce. dfdd0ce is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
@github-actions crossbow submit java-jars |
Revision: ca4a0b5 Submitted crossbow builds: ursacomputing/crossbow @ actions-35540857ab
|
…er tests (apache#14210)" This reverts commit dfdd0ce.
@lidavidm It seems that this breaks the "java-jars" job:
Could you take a look at this? |
Sorry. I'm just going to remove the JaCoCo check since it makes things flaky (I think whether JaCoCo fails or not is just down to chance on whether the new branch gets hit) |
…apache#14210) I couldn't reproduce it, so I added a suppression instead. In both cases, the error is that the server is uncontactable. That shouldn't happen, but I changed the tests to also bind to port 0 instead of using a potentially flaky free port finder. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
…apache#14210) I couldn't reproduce it, so I added a suppression instead. In both cases, the error is that the server is uncontactable. That shouldn't happen, but I changed the tests to also bind to port 0 instead of using a potentially flaky free port finder. Authored-by: David Li <[email protected]> Signed-off-by: David Li <[email protected]>
I couldn't reproduce it, so I added a suppression instead.
In both cases, the error is that the server is uncontactable. That shouldn't happen, but I changed the tests to also bind to port 0 instead of using a potentially flaky free port finder.