Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARROW-17785: [Java] Suppress flakiness from gRPC in JDBC driver tests #14210

Merged
merged 1 commit into from
Sep 23, 2022

Conversation

lidavidm
Copy link
Member

I couldn't reproduce it, so I added a suppression instead.

In both cases, the error is that the server is uncontactable. That shouldn't happen, but I changed the tests to also bind to port 0 instead of using a potentially flaky free port finder.

@github-actions
Copy link

Copy link
Contributor

@lwhite1 lwhite1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lidavidm lidavidm merged commit dfdd0ce into apache:master Sep 23, 2022
@lidavidm lidavidm deleted the arrow-17785 branch September 23, 2022 13:51
@lidavidm
Copy link
Member Author

FYI @jduo if you have a better idea of the root cause here

@ursabot
Copy link

ursabot commented Sep 23, 2022

Benchmark runs are scheduled for baseline = bed6f8e and contender = dfdd0ce. dfdd0ce is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished ⬇️0.0% ⬆️0.0%] ec2-t3-xlarge-us-east-2
[Failed ⬇️0.41% ⬆️0.0%] test-mac-arm
[Failed ⬇️0.27% ⬆️0.0%] ursa-i9-9960x
[Finished ⬇️0.21% ⬆️0.0%] ursa-thinkcentre-m75q
Buildkite builds:
[Finished] dfdd0ceb ec2-t3-xlarge-us-east-2
[Failed] dfdd0ceb test-mac-arm
[Failed] dfdd0ceb ursa-i9-9960x
[Finished] dfdd0ceb ursa-thinkcentre-m75q
[Finished] bed6f8e5 ec2-t3-xlarge-us-east-2
[Finished] bed6f8e5 test-mac-arm
[Failed] bed6f8e5 ursa-i9-9960x
[Finished] bed6f8e5 ursa-thinkcentre-m75q
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kou
Copy link
Member

kou commented Sep 25, 2022

@github-actions crossbow submit java-jars

@github-actions
Copy link

Revision: ca4a0b5

Submitted crossbow builds: ursacomputing/crossbow @ actions-35540857ab

Task Status
java-jars Github Actions

kou added a commit to kou/arrow that referenced this pull request Sep 25, 2022
@kou
Copy link
Member

kou commented Sep 25, 2022

@lidavidm It seems that this breaks the "java-jars" job:

https://github.com/ursacomputing/crossbow/actions/runs/3120934243/jobs/5062134840#step:7:55283

Warning:  Rule violated for class org.apache.arrow.driver.jdbc.client.ArrowFlightSqlClientHandler.1: branches covered ratio is 0.25, but expected minimum is 0.80
...
Error:  Failed to execute goal org.jacoco:jacoco-maven-plugin:0.8.7:check (check) on project flight-sql-jdbc-driver: Coverage checks have not been met. See log for details. -> [Help 1]
Error:  
Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
Error:  Re-run Maven using the -X switch to enable full debug logging.
Error:  
Error:  For more information about the errors and possible solutions, please read the following articles:
Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
Error:  
Error:  After correcting the problems, you can resume the build with the command
Error:    mvn <args> -rf :flight-sql-jdbc-driver
Error: Process completed with exit code 1.

Could you take a look at this?

@lidavidm
Copy link
Member Author

Sorry. I'm just going to remove the JaCoCo check since it makes things flaky (I think whether JaCoCo fails or not is just down to chance on whether the new branch gets hit)

#14231

zagto pushed a commit to zagto/arrow that referenced this pull request Oct 7, 2022
…apache#14210)

I couldn't reproduce it, so I added a suppression instead. 

In both cases, the error is that the server is uncontactable. That shouldn't happen, but I changed the tests to also bind to port 0 instead of using a potentially flaky free port finder.

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
fatemehp pushed a commit to fatemehp/arrow that referenced this pull request Oct 17, 2022
…apache#14210)

I couldn't reproduce it, so I added a suppression instead. 

In both cases, the error is that the server is uncontactable. That shouldn't happen, but I changed the tests to also bind to port 0 instead of using a potentially flaky free port finder.

Authored-by: David Li <[email protected]>
Signed-off-by: David Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants