ARROW-12393: [JS] Use closure compiler for all UMD targets #10281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Opening JIRAs ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename pull request title in the following format? or See also: |
domoritz
changed the title
trxcllnt
approved these changes
May 15, 2021
domoritz
commented
May 15, 2021
| @@ -2,10 +2,10 @@ | |||
| { | |||
| "extends": "./tsconfig.base.json", | |||
| "compilerOptions": { | |||
| "target": "ES2015", | |||
There was a problem hiding this comment.
@trxcllnt why was this es2015? The output was always only used for closure so all .cls.json files should be identical, no?
There was a problem hiding this comment.
Apparently the documentation for this file was incorrect.
|
Ahh, looks like the build system tricked me. We should use closure for everything. |
domoritz
changed the title
is wrong then. We use the .cls config also for terser and not just closure.
|
Co-authored-by: P42 <72252241+p42-ai[bot]@users.noreply.github.com> Co-authored-by: Dominik Moritz <[email protected]>
domoritz
changed the title
|
I updated the pull request to use closure for every target. |
domoritz
changed the title
domoritz
changed the title
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Closure compiler creates smaller bundles. This branch ``` targets/es5/umd/: 695k -I Arrow.es5.min.js.map 55k -I Arrow.externs.js 254k -I Arrow.js targets/es2015/umd/: 534k -I Arrow.es2015.min.js.map 55k -I Arrow.externs.js 180k -I Arrow.js targets/esnext/umd/: 512k -I Arrow.esnext.min.js.map 55k -I Arrow.externs.js 172k -I Arrow.js ``` Master (which uses closure only for es5 targets and terser otherwise) ``` targets/es5/umd/: 694k -I Arrow.es5.min.js.map 55k -I Arrow.externs.js 253k -I Arrow.js targets/es2015/umd/: 1.2M -I Arrow.es2015.min.js.map 233k -I Arrow.js targets/esnext/umd/: 1.1M -I Arrow.esnext.min.js.map 225k -I Arrow.js ``` Closes apache#10281 from domoritz/dom/closure-everything-but-es5 Lead-authored-by: Dominik Moritz <[email protected]> Co-authored-by: p42-ai[bot] <72252241+p42-ai[bot]@users.noreply.github.com> Signed-off-by: Dominik Moritz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closure compiler creates smaller bundles.
This branch
Master (which uses closure only for es5 targets and terser otherwise)