ARROW-12704: [JS] Support and use optional chaining #10278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domoritz
changed the title
trxcllnt
approved these changes
May 15, 2021
Co-authored-by: P42 <72252241+p42-ai[bot]@users.noreply.github.com> Co-authored-by: Dominik Moritz <[email protected]>
|
@domoritz Could you also rebase on master and update the pull request description? |
|
I merged master and updated the description. |
|
I also merged this branch into the follow-up at #10281. No idea why this one is failing. |
|
Thanks. These failures are unrelated. |
michalursa
pushed a commit
to michalursa/arrow
that referenced
this pull request
Jun 13, 2021
Optional chaining makes the code more concise and easier to reason about. Needs a fork of esm because of standard-things/esm#866. Closes apache#10278 from domoritz/modern-js Lead-authored-by: Dominik Moritz <[email protected]> Co-authored-by: p42-ai[bot] <72252241+p42-ai[bot]@users.noreply.github.com> Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional chaining makes the code more concise and easier to reason about.
Needs a fork of esm because of standard-things/esm#866.