minor: use as_boolean to resolve TODO #4367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackwener
changed the title
tustvold
reviewed
Jun 5, 2023
arrow-select/src/take.rs
Outdated
| @@ -476,7 +476,7 @@ where | |||
| } | |||
|
|
|||
| /// `take` implementation for boolean arrays | |||
| fn take_boolean<IndexType>( | |||
| pub fn take_boolean<IndexType>( | |||
There was a problem hiding this comment.
I'm not sure about this, we currently don't expose these both to keep the API surface down
arrow-ord/src/comparison.rs
Outdated
| @@ -1196,8 +1196,7 @@ where | |||
| K: ArrowDictionaryKeyType, | |||
| K::Native: num::ToPrimitive, | |||
| { | |||
| // TODO: Use take_boolean (#2967) | |||
| let array = take(&dict_comparison, dict.keys(), None)?; | |||
| let array = take_boolean(&dict_comparison, dict.keys())?; | |||
There was a problem hiding this comment.
Suggested change
| let array = take_boolean(&dict_comparison, dict.keys())?; | |
| let array = take(&dict_comparison, dict.keys())?.as_boolean().clone(); |
Perhaps? The overhead of the dyn dispatch and clone is irrelevant in the grand scheme of things. The linked issue #2967 was closed as not planned
|
Thanks @tustvold review |
tustvold
approved these changes
Jun 6, 2023
tustvold
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?