Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Statically Typed Take/Filter Kernels #2967

Closed
tustvold opened this issue Oct 28, 2022 · 1 comment
Closed

Expose Statically Typed Take/Filter Kernels #2967

tustvold opened this issue Oct 28, 2022 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted

Comments

@tustvold
Copy link
Contributor

Is your feature request related to a problem or challenge? Please describe what you are trying to do.

Sometimes I want to call a filter or take kernel with a known static type, and get back that type

Describe the solution you'd like

We already have specialized take_primitive, filter_primitive, etc... kernels, we should just expose these publicly

Describe alternatives you've considered

Additional context
@tustvold tustvold added enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted labels Oct 28, 2022
@tustvold tustvold mentioned this issue Oct 29, 2022
Closed
tustvold added a commit to tustvold/arrow-rs that referenced this issue Dec 9, 2022
@tustvold
Make statically typed take kernels public (apache#2967)
b696bb0
@tustvold tustvold mentioned this issue Dec 9, 2022
Closed
@viirya viirya mentioned this issue Jan 3, 2023
Closed
@tustvold
Copy link
Contributor Author

tustvold commented Apr 1, 2023

An alternative would be to use trait based dispatch as described in #3999

@tustvold tustvold closed this as not planned Won't fix, can't repro, duplicate, stale Jun 1, 2023
@tustvold tustvold mentioned this issue Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Any new improvement worthy of a entry in the changelog good first issue Good for newcomers help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose Statically Typed Take/Filter Kernels viirya/arrow-rs
1 participant
@tustvold