-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix fmt + Mac CI jobs #2287
Fix fmt + Mac CI jobs #2287
Conversation
997b884
to
0544d4e
Compare
0544d4e
to
454fee8
Compare
Example Lint job success: https://github.com/apache/arrow-rs/runs/7638759965?check_suite_focus=true Example Mac job: https://github.com/apache/arrow-rs/runs/7638760241?check_suite_focus=true Example coverage job: https://github.com/apache/arrow-rs/runs/7638759453?check_suite_focus=true |
This is a strange error: https://github.com/apache/arrow-rs/runs/7639063643?check_suite_focus=true If it passes on rerun I'll file a ticket
Updated filed #2288 |
I am merging this one in because I think it is non controversial and I want to get CI coverage back up. I am happy to make any changes requested in a follow on PR |
Benchmark runs are scheduled for baseline = 3e17891 and contender = 6b2c757. 6b2c757 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Relates to #2279
Rationale for this change
The
windows
,Mac
,fmt
andcodecov
CI checks are broken currentlyWhat changes are included in this PR?
Fix
Mac
, andfmt
CI checksI am still working on Windows and Coverage (see my flailing attempts at #2280) but I think it is important to restore the CI checks sooner rather than later
Are there any user-facing changes?
No