-
Notifications
You must be signed in to change notification settings - Fork 849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Coverage/Mac/Windows CI #2280
Conversation
60e1b9f
to
46c8964
Compare
Codecov Report
@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
- Coverage 82.29% 82.21% -0.08%
==========================================
Files 245 246 +1
Lines 62688 63367 +679
==========================================
+ Hits 51586 52096 +510
- Misses 11102 11271 +169
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
a3243c5
to
c3b522c
Compare
Benchmark runs are scheduled for baseline = ec83638 and contender = 577a93b. 577a93b is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Draft as I test and until I have restored the other workflowsWhich issue does this PR close?
Closes #2279
Rationale for this change
The protobuf compiler,
protoc
needed forarrow-flight
is no longer bundled with post, so we need to fix the github builders to have itWhat changes are included in this PR?
protoc
correctly on windows builderprotoc
correctly on coverage builder (which can't use docker)Are there any user-facing changes?
No