Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Copy trait bound from dyn scalar kernels #1243

Merged
merged 1 commit into from
Jan 27, 2022
Merged

Remove Copy trait bound from dyn scalar kernels #1243

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions arrow/src/compute/kernels/comparison.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1181,7 +1181,7 @@ macro_rules! dyn_compare_utf8_scalar {
/// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values
pub fn eq_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray>
where
T: num::ToPrimitive + Copy + std::fmt::Debug,
T: num::ToPrimitive + std::fmt::Debug,
{
match left.data_type() {
DataType::Dictionary(key_type, _value_type) => {
Expand All @@ -1195,7 +1195,7 @@ where
/// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values
pub fn lt_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray>
where
T: num::ToPrimitive + Copy + std::fmt::Debug,
T: num::ToPrimitive + std::fmt::Debug,
{
match left.data_type() {
DataType::Dictionary(key_type, _value_type) => {
Expand All @@ -1209,7 +1209,7 @@ where
/// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values
pub fn lt_eq_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray>
where
T: num::ToPrimitive + Copy + std::fmt::Debug,
T: num::ToPrimitive + std::fmt::Debug,
{
match left.data_type() {
DataType::Dictionary(key_type, _value_type) => {
Expand All @@ -1223,7 +1223,7 @@ where
/// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values
pub fn gt_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray>
where
T: num::ToPrimitive + Copy + std::fmt::Debug,
T: num::ToPrimitive + std::fmt::Debug,
{
match left.data_type() {
DataType::Dictionary(key_type, _value_type) => {
Expand All @@ -1237,7 +1237,7 @@ where
/// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values
pub fn gt_eq_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray>
where
T: num::ToPrimitive + Copy + std::fmt::Debug,
T: num::ToPrimitive + std::fmt::Debug,
{
match left.data_type() {
DataType::Dictionary(key_type, _value_type) => {
Expand All @@ -1251,7 +1251,7 @@ where
/// value. Supports PrimitiveArrays, and DictionaryArrays that have primitive values
pub fn neq_dyn_scalar<T>(left: &dyn Array, right: T) -> Result<BooleanArray>
where
T: num::ToPrimitive + Copy + std::fmt::Debug,
T: num::ToPrimitive + std::fmt::Debug,
{
match left.data_type() {
DataType::Dictionary(key_type, _value_type) => {
Expand Down