Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Copy trait bound from dyn scalar kernels #1243

Merged

Conversation

matthewmturner
Copy link
Contributor

Which issue does this PR close?

No existing issue.

Rationale for this change

In the context of apache/datafusion#1685 I am trying to use datafusions ScalarValue with the dyn scalar kernels. We now use the ToPrimitive trait for the dyn scalar kernels and I am looking to implement that on ScalarValue as well. While testing that locally the last issue i came across was ScalarValue not implementing Copy which the dyn scalar kernels require. I tried removing that constraint locally and had no issues compiling / testing / linting so im thinking the constraint isnt needed.

@alamb FYI.

What changes are included in this PR?

Removing Copy trait requirement on the dyn scalar kernels.

Are there any user-facing changes?

@github-actions github-actions bot added the arrow Changes to the arrow crate label Jan 27, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1243 (2af8e90) into master (731e132) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 2af8e90 differs from pull request most recent head 6d657bb. Consider uploading reports for the commit 6d657bb to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1243      +/-   ##
==========================================
- Coverage   82.96%   82.95%   -0.01%     
==========================================
  Files         178      178              
  Lines       51522    51522              
==========================================
- Hits        42743    42742       -1     
- Misses       8779     8780       +1     
Impacted Files Coverage Δ
arrow/src/compute/kernels/comparison.rs 91.70% <ø> (ø)
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 84.64% <0.00%> (-0.13%) ⬇️
arrow/src/datatypes/datatype.rs 66.80% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731e132...6d657bb. Read the comment docs.

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find @matthewmturner 👍

@alamb alamb added the enhancement Any new improvement worthy of a entry in the changelog label Jan 27, 2022
@alamb alamb merged commit fb581f3 into apache:master Jan 27, 2022
@alamb alamb changed the title Remove Copy trait from dyn scalar kernels Remove Copy trait requirement from dyn scalar kernels Feb 3, 2022
@alamb alamb changed the title Remove Copy trait requirement from dyn scalar kernels Remove Copy trait bound from dyn scalar kernels Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrow Changes to the arrow crate enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants