Remove Copy
trait bound from dyn scalar kernels
#1243
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No existing issue.
Rationale for this change
In the context of apache/datafusion#1685 I am trying to use datafusions
ScalarValue
with the dyn scalar kernels. We now use theToPrimitive
trait for the dyn scalar kernels and I am looking to implement that onScalarValue
as well. While testing that locally the last issue i came across wasScalarValue
not implementingCopy
which the dyn scalar kernels require. I tried removing that constraint locally and had no issues compiling / testing / linting so im thinking the constraint isnt needed.@alamb FYI.
What changes are included in this PR?
Removing
Copy
trait requirement on the dyn scalar kernels.Are there any user-facing changes?