Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Sensitive Variable fields feature #9446

Merged
merged 4 commits into from
Jun 20, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jun 20, 2020

#9397 added this feature but broke Master


Make sure to mark the boxes below before creating PR: [x]

  • Description above provides context of the change
  • Unit tests coverage for changes (not needed for documentation changes)
  • Target Github ISSUE in description if exists
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions.
  • I will engage committers as explained in Contribution Workflow Example.

In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.

@kaxil kaxil requested review from potiuk and mik-laj June 20, 2020 16:04
@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jun 20, 2020
Copy link
Member

@ashb ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still not 100% happy though

@kaxil
Copy link
Member Author

kaxil commented Jun 20, 2020

Tests still not 100% happy though

-----------------------------------------------------------------------------------------------
-----------------------------------------------------------------------------------------------
             Checking integration openldap
-----------------------------------------------------------------------------------------------

             Integration openldap OK!

-----------------------------------------------------------------------------------------------

Error: some of the CI environment failed to initialize!

###########################################################################################
                   EXITING /opt/airflow/scripts/ci/in_container/check_environment.sh WITH STATUS CODE 254
###########################################################################################

Error: check_environment returned 254. Exiting.

###########################################################################################
                   EXITING /entrypoint WITH STATUS CODE 254
###########################################################################################
###########################################################################################
                   EXITING WITH STATUS CODE 254
###########################################################################################

Finished the script ci_run_airflow_testing.sh
Elapsed time spent in the script: 139 seconds
Exit code 254

Environment related issue in one of the tests

@potiuk
Copy link
Member

potiuk commented Jun 20, 2020

still test_can_handle_error_on_decrypt fails consistently :(

@kaxil
Copy link
Member Author

kaxil commented Jun 20, 2020

still test_can_handle_error_on_decrypt fails consistently :(

Yup, fixing it too

@kaxil kaxil merged commit 47a6402 into apache:master Jun 20, 2020
@kaxil kaxil deleted the fix-ci-sensitive-vars branch June 20, 2020 18:43
kaxil added a commit to kaxil/airflow that referenced this pull request Jun 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants