-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options to extend list of sensitive keywords #9397
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add tests to avoid regression?
sure, I will take a look and update here |
Deleted |
@Marloxo Sorry. I wanted to publish it in another PR. |
@mik-laj no worries, any advice what tests I shall add ? |
You should use tests.test_utils.config.conf_vars decorator and check the configration option and return value. I would be happy if you would use parameterized to easily check many cases. |
3bf24ed
to
f22e3a3
Compare
@mik-laj I updated the PR with tests, would you please take a look. |
Can you also add docs to https://airflow.readthedocs.io/en/latest/security.html? |
f22e3a3
to
9949964
Compare
change DEFAULT_SENSITIVE_VARIABLE_FIELDS to set instead of tuple add tests for SENSITIVE_VARIABLE_FIELDS
9949964
to
1c02123
Compare
DEFAULT_SENSITIVE_VARIABLE_FIELDS
Awesome work, congrats on your first merged pull request! |
The tests were failing for this PR, it broke Master. Created a PR to fix it: #9446 |
Make sure to mark the boxes below before creating PR: [x]
this PR addressed the following issue: #9372
basically it's adding support for additional labels from the configuration so users can extend the matching of sensitive keywords in variables name.