Fix the argument type of input_vectors in pinecone upsert #39688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunank200
force-pushed
the
fix_pinecone_system_test
branch
from
82ab91f to
9ef1b86
Compare
dstandish
approved these changes
May 17, 2024
vatsrahul1001
approved these changes
May 17, 2024
utkarsharma2
approved these changes
May 17, 2024
romsharon98
pushed a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* Fix the argument type of input_vectors * Fix typing and docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
example_pinecone_cohereDAG of the system test is broken after PR #37307 is merged.The upstream
pinecone-client>=3.0.0accepts vector asUnion[List[Vector], List[tuple], List[dict]]as per https://github.com/pinecone-io/pinecone-python-client/blob/main/pinecone/data/index.py#L100. But the previous implementation only acceptedlist[tuples]andlist[Any]which is wrong. Hence the dag is breaking as the previous client acceptedlist[list[float]]as well. I have added a transformation method to fix this.I have tested this DAG with the change.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.