Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pinecone provider support for pinecone-client>=3 #37307

Merged
merged 61 commits into from
Apr 30, 2024

Conversation

rawwar
Copy link
Collaborator

@rawwar rawwar commented Feb 10, 2024

closes: #37158

Adds support for pinecone-client >= 3.x

Migration checks

  • Index creation
  • handle updated(breaking change) response from list_indexes and list_collections
  • handle describe_index response change
  • handle changes to positional arguments in query method.
  • handle removal of multiple queries support using queries keyword in query method
  • handle removal of scale_index
  • PINECONE_DEBUG_CURL support for debug logs

Additional tasks:

  • Documentation update
  • changelog
  • add/update tests
  • add example dag's for new operators

Copy link
Contributor

@dirrao dirrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it backward compatible? Does it break during upgrade?
If so, it's worth to mention the same in the release notes about this breaking change.

@Taragolis
Copy link
Contributor

Does it backward compatible? Does it break during upgrade?

Difficult to say right now, in general bump dependency version is not a breaking changes, if all other components remain unchanged or compatible.

Copy link

github-actions bot commented Apr 7, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 7, 2024
@eladkal eladkal removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Apr 13, 2024
airflow/providers/pinecone/CHANGELOG.rst Outdated Show resolved Hide resolved
airflow/providers/pinecone/CHANGELOG.rst Outdated Show resolved Hide resolved
airflow/providers/pinecone/CHANGELOG.rst Show resolved Hide resolved
@rawwar
Copy link
Collaborator Author

rawwar commented Apr 24, 2024

@sunank200 , @Lee-W, Do you have any more feedback for the PR?

@Lee-W Lee-W self-requested a review April 25, 2024 09:16
@rawwar rawwar requested review from Lee-W and sunank200 April 26, 2024 14:16
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support pinecone-client to 3.0+
7 participants