Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dns_config and diagnostics parameters to AzureContainerInstancesOperator #39156

Conversation

Kylea650
Copy link
Contributor

Closes #39149

When creating a container using the AzureContainerInstanceOperator, it would be good to be able to pass a specific dns configuration and log analytics workspace. These are already supported by the azure management api.

Non-breaking change that adds some nice extra functionality. In some cases, providing an explicit dns config is required for private containers when existing VNet DNS is not picked up. (see https://stackoverflow.com/questions/64700687/how-to-get-azure-container-instances-using-my-dns-server). Adding the ability to send logs to an existing log analytics workspace is a nice quality of life addition for sending non-airflow, application specific logs.

Happy to add more tests if required.

Copy link

boring-cyborg bot commented Apr 21, 2024

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: [email protected]
    Slack: https://s.apache.org/airflow-slack

@Kylea650 Kylea650 force-pushed the add-dnsconfig-loganalytics-to-AzureContainterInstancesOperator branch from d40c742 to fcd06a4 Compare April 22, 2024 16:32
@potiuk potiuk merged commit df1f75b into apache:main Apr 25, 2024
41 checks passed
Copy link

boring-cyborg bot commented Apr 25, 2024

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add DNS config and log analytics to AzureContainerInstanceOperator
3 participants