-
Notifications
You must be signed in to change notification settings - Fork 14.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dns_config and diagnostics parameters to AzureContainerInstancesOperator #39156
add dns_config and diagnostics parameters to AzureContainerInstancesOperator #39156
Conversation
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
d40c742
to
fcd06a4
Compare
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Closes #39149
When creating a container using the AzureContainerInstanceOperator, it would be good to be able to pass a specific dns configuration and log analytics workspace. These are already supported by the azure management api.
Non-breaking change that adds some nice extra functionality. In some cases, providing an explicit dns config is required for private containers when existing VNet DNS is not picked up. (see https://stackoverflow.com/questions/64700687/how-to-get-azure-container-instances-using-my-dns-server). Adding the ability to send logs to an existing log analytics workspace is a nice quality of life addition for sending non-airflow, application specific logs.
Happy to add more tests if required.