Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS config and log analytics to AzureContainerInstanceOperator #39149

Closed
2 tasks done
Kylea650 opened this issue Apr 20, 2024 · 1 comment · Fixed by #39156
Closed
2 tasks done

Add DNS config and log analytics to AzureContainerInstanceOperator #39149

Kylea650 opened this issue Apr 20, 2024 · 1 comment · Fixed by #39156

Comments

@Kylea650
Copy link
Contributor

Description

When creating a container using the AzureContainerInstanceOperator, it would be good to have the ability to provide DNS configuration and to be able to hook up an existing log analytics workspace.

Example from Azure SDK:
https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/containerinstance/azure-mgmt-containerinstance/generated_samples/container_groups_create_or_update.py

Use case/motivation

When creating a container instance in a subnet/vnet, azure does not automatically resolve DNS (as it does for VMs). So we need to pass the custom name servers when creating the container group as per: https://learn.microsoft.com/en-us/azure/container-instances/container-instances-custom-dns

These settings already exist in the mgmt api used by the ContainerGroupsOperator so should be an easy addition.

additionally, it would nice to be able to hook up an existing log analytics workspace when creating a container instance. This is also available in the mgmt api.

happy to submit a PR.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@Kylea650 Kylea650 added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels Apr 20, 2024
Copy link

boring-cyborg bot commented Apr 20, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants