Avoid creating the hook in the EmrServerlessCancelJobsTrigger init #35992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:amazon-aws
vincbeck
approved these changes
Nov 30, 2023
o-nikolas
approved these changes
Nov 30, 2023
hussein-awala
commented
Nov 30, 2023
Comment on lines
+465
to
+468
| @property | ||
| def hook_instance(self) -> AwsGenericHook: | ||
| """This property is added for backward compatibility.""" | ||
| return self.hook() |
There was a problem hiding this comment.
I added hook_instance as a property, so it will be available when the user tries to access it, but it's lazy evaluated and created only when accessing it.
That makes the change backward compatible.
I dont think this qualify as breaking change |
50 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might be considered a breaking change, but it's completely useless to create the hook in the init method because we create an instance from the trigger in the operator when we defer it, which means an extra needed DB query to fetch the secrets.
The original reason for this implementation was accessing
JOB_INTERMEDIATE_STATESlist, which is a class param, so no need to create an instance from the class to get it.cc: @eladkal