Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing Providers that were prepared on December 08, 2023 #36117

Closed
22 of 50 tasks
eladkal opened this issue Dec 7, 2023 · 13 comments
Closed
22 of 50 tasks

Status of testing Providers that were prepared on December 08, 2023 #36117

eladkal opened this issue Dec 7, 2023 · 13 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@eladkal
Copy link
Contributor

eladkal commented Dec 7, 2023

Body

I have a kind request for all the contributors to the latest provider packages release.
Could you please help us to test the RC versions of the providers?

The guidelines on how to test providers can be found in

Verify providers by contributors

Let us know in the comment, whether the issue is addressed.

Those are providers that require testing as there were some substantial changes introduced:

Provider amazon: 8.13.0rc1

Provider cncf.kubernetes: 7.11.0rc1

Provider docker: 3.9.0rc1

Provider elasticsearch: 5.3.0rc1

Provider google: 10.13.0rc1

Provider http: 4.8.0rc1

Provider jdbc: 4.2.0rc1

Provider microsoft.azure: 8.4.0rc1

Provider microsoft.mssql: 3.6.0rc1

Provider openai: 1.1.0rc1

Provider openlineage: 1.3.0rc1

Provider trino: 5.5.0rc1

Provider weaviate: 1.1.0rc1

All users involved in the PRs:
@Taragolis @vincbeck @romsharon98 @syedahsn @kacpermuda @raphaelauv @melugoyal @ginolegigot @atrbgithub @flolas @JDarDagran @nathadfield @potiuk @ephraimbuddy @Joffreybvn @pankajkoti @hussein-awala
@VladaZakharova @stavdav143 @eladkal

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added kind:meta High-level information important to the community testing status Status of testing releases labels Dec 7, 2023
@melugoyal
Copy link
Contributor

#35694 working as expected

airflow-oss-bot added a commit to astronomer/astronomer-providers that referenced this issue Dec 8, 2023
airflow-oss-bot added a commit to astronomer/astro-sdk that referenced this issue Dec 8, 2023
@atrbgithub
Copy link
Contributor

atrbgithub commented Dec 8, 2023

An issue has been raised with #34919

Unfortunately it looks like it has broken GCSObjectsWithPrefixExistenceSensor.

Testing myself I can confirm that the following code is able to create the error:

from airflow.providers.google.cloud.hooks.gcs import GCSHook
res = GCSHook().list(
        bucket_name='a-testbucket',
        prefix='a/prefix/in/the/bucket/'
)
print(res)

Please do not include this change.

Edit: I've raised a PR #36130 which appears to fix this issue for me when testing locally.

@eladkal
Copy link
Contributor Author

eladkal commented Dec 9, 2023

Docker provider will be excluded from rc1

@hussein-awala
Copy link
Member

I tested my change on the Kubernetes executor, and most of the changes in the Amazon provider, all work as expected.

@pankajastro
Copy link
Member

As @atrbgithub has mentioned above #34919 is breaking an existing DAG. so we might need to exclude Google provider

@eladkal
Copy link
Contributor Author

eladkal commented Dec 9, 2023

so we might need to exclude Google provider

Yes. Google provider will also have RC2

@potiuk
Copy link
Member

potiuk commented Dec 10, 2023

Tested mssql - all looks good.

One more thing I noticed - the removed daskexecutor has not been prepared. We have this in the release process, so it's easy to miss:

NOTE! When you want to release a provider marked for removal (needed in order to prepare last release of the provider), package for the provider will not be prepared when you prepare documentation for all providers - you have to specifically use the provider name in a separate command. For example to prepare documentation for removed.provider provider marked for removal you need to run separately this command:

breeze release-management prepare-provider-packages --package-format both removed.provider

But maybye we will change it in the future - we have more removed providers coming. So possibly we shoudl automatically add removed providers to the list of providers prepared (both for documentation and package building - so that we do not have to remember to prepare them. That was probably bad idea to not add them in the first place.

@eladkal -> I guess we should include rc2 (even if there was no rc1) for daskexecutor.

@potiuk
Copy link
Member

potiuk commented Dec 10, 2023

One small update - as @pankajastro noticed in #32319 (comment) - there is a case where we are not handling properly the fact that handler can return either list of rows or row - in both ODBC and DAtabricks oviders, so IMHO they should also be moved to RC2 (cc: @Joffreybvn )

@potiuk
Copy link
Member

potiuk commented Dec 10, 2023

Fix to the process to automatically generate removed providers here: #36160

@Joffreybvn
Copy link
Contributor

Fix for #32319 (comment) is here -> #36161

@nathadfield
Copy link
Collaborator

#36072 has been tested and working as expected.

@eladkal
Copy link
Contributor Author

eladkal commented Dec 12, 2023

Providers: Google, ODBC, Databricks, Docker are excluded from RC1.

@eladkal
Copy link
Contributor Author

eladkal commented Dec 12, 2023

Thank you everyone.
Providers are released (excluding Google, ODBC, Databricks, Docker which we will have RC2 soon)
I invite everyone to help improve providers for the next release, a list of open issues can be found here.

@eladkal eladkal closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

8 participants