Fix query bug in next_run_datasets_summary endpoint #34143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query to get the dataset_triggered_dag_ids in the next_run_datasets_summary endpoint errors with `str` object has no attribute dag_id. This issue is from a recent refactor on sqlalchemy queries and the view has no unit test to detect it. I added a fix with a unit test
ephraimbuddy
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
Taragolis
approved these changes
Sep 6, 2023
hussein-awala
approved these changes
Sep 6, 2023
ephraimbuddy
added a commit
that referenced
this pull request
Oct 5, 2023
The query to get the dataset_triggered_dag_ids in the next_run_datasets_summary endpoint errors with `str` object has no attribute dag_id. This issue is from a recent refactor on sqlalchemy queries and the view has no unit test to detect it. I added a fix with a unit test (cherry picked from commit 79abcfa)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The query to get the dataset_triggered_dag_ids in the next_run_datasets_summary endpoint errors with
strobject has no attribute dag_id. This issue is from a recent refactor on sqlalchemy queries and the view has no unit test to detect it. I added a fix with a unit test