Bump min-version for docker and docker-compose #33572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
force-pushed
the
bump-min-versions-for-docker-and-compose-in-breeze
branch
2 times, most recently
from
94f5177 to
3798694
Compare
uranusjr
approved these changes
Aug 21, 2023
eladkal
approved these changes
Aug 21, 2023
potiuk
force-pushed
the
bump-min-versions-for-docker-and-compose-in-breeze
branch
2 times, most recently
from
e74af83 to
e68e8b8
Compare
|
OK. Seems that even our CI's docker is too old :) |
|
But it looks like the version check works nicely BTW :) |
It's been quite some time since we bumped min versions for docker and docker-compose for Breeze and there are already a few cases where it held us back from more efficiently using some newer docker or docker-compose features (for example in apache#33547). Also docker-compose v1 is sufficiently old an unmaintained, that it's about time to get rid of it and ask the users to migrate to docker-compose v2. The new min versions propose: * Docker: 23.0.0 released 2023-02-01 (6 months ago) * Docker Compose 2.14.0 release 2022-12-15 (8 months ago) Docker v1 is not supported any more and the users are directed to migrate to v2 to continue using Breeze.
potiuk
force-pushed
the
bump-min-versions-for-docker-and-compose-in-breeze
branch
from
e68e8b8 to
a125733
Compare
|
Ok. We should have now docker and docker compose updated for our self-hosted runners. Let's see. |
|
So far so good:
I set-up the "min-versions" in CI that correspond to the min-versions we have in Breeze - this way we will see in CI if we introduce something not supported by those in most cases (since we are running almost all our breeze commands as part of the CI jobs of ours). |
potiuk
added
the
use public runners
|
Looks great. Trying on public runners, just in case. |
jedcunningham
approved these changes
Aug 21, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
Oct 5, 2023
It's been quite some time since we bumped min versions for docker and docker-compose for Breeze and there are already a few cases where it held us back from more efficiently using some newer docker or docker-compose features (for example in #33547). Also docker-compose v1 is sufficiently old an unmaintained, that it's about time to get rid of it and ask the users to migrate to docker-compose v2. The new min versions propose: * Docker: 23.0.0 released 2023-02-01 (6 months ago) * Docker Compose 2.14.0 release 2022-12-15 (8 months ago) Docker v1 is not supported any more and the users are directed to migrate to v2 to continue using Breeze. (cherry picked from commit 73a3733)
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been quite some time since we bumped min versions for docker and docker-compose for Breeze and there are already a few cases where it held us back from more efficiently using some newer docker or docker-compose features (for example in #33547). Also docker-compose v1 is sufficiently old an unmaintained, that it's about time to get rid of it and ask the users to migrate to docker-compose v2.
The new min versions propose:
Docker v1 is not supported any more and the users are directed to migrate to v2 to continue using Breeze.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.