Remove print from dag trigger command #30921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pankajastro
changed the title
pankajastro
force-pushed
the
remove_print_from_trigger_dag_cmd
branch
from
cd4803f to
3f2edcd
Compare
pankajastro
force-pushed
the
remove_print_from_trigger_dag_cmd
branch
from
3f2edcd to
8939ab1
Compare
potiuk
approved these changes
Apr 29, 2023
ephraimbuddy
pushed a commit
that referenced
this pull request
May 8, 2023
(cherry picked from commit 36fe6d0)
34 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, we added output format arg in
airflow dag trigger <dag_id>commandbecause of that, we are getting the result twice in the console.
first because of old print statements and 2nd because of AirflowConsole().print_as.
I feel we should remove the print statement now.
before
after
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.