Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing of Apache Airflow 2.6.1rc3 #31202

Closed
14 of 34 tasks
ephraimbuddy opened this issue May 11, 2023 · 8 comments
Closed
14 of 34 tasks

Status of testing of Apache Airflow 2.6.1rc3 #31202

ephraimbuddy opened this issue May 11, 2023 · 8 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@ephraimbuddy
Copy link
Contributor

ephraimbuddy commented May 11, 2023

Body

We are kindly requesting that contributors to Apache Airflow RC 2.6.1rc1 help test the RC.

Please let us know by commenting if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@pierrejeambrun @LipuFei @pankajastro @JCoder01 @davidshur @zachliu @meujin @LuizArmesto @Limess @AmFlint @juraa14 @jedcunningham @tatiana @bbovenzi @huozhanfeng @herlambang @sarvothaman @chriscmorgan @potiuk @eejbyfeldt @dstandish @awbush @mtsadler-branch @dimonchik-suvorov @ashb @ephraimbuddy

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@ephraimbuddy ephraimbuddy added the kind:meta High-level information important to the community label May 11, 2023
@LipuFei
Copy link
Contributor

LipuFei commented May 11, 2023

Hi @ephraimbuddy , I've just tested #31033, but the DB job still fails due to another circular import. I found a fix for this. Can I directly make a new PR or should I also raise an issue for this?

UPDATE: I've created a PR to fix this #31204
UPDATE 2: #31204 was merged.

@herlambang
Copy link
Contributor

UAT Test Result v2.6.1rc1

Dashboard Footer:
Version: v2.6.1
Git Version: .release:06e3aa3e40948efcb53e9320b78d6b33b875ad12

Fix unable to remove DagRun and TaskInstance with note (#30987)

  • open page /dagrun/list/
  • edit 1 dag run, fill note field and save
  • delete dag run previously edited
  • dag run deleted
  • open page /taskinstance/list/
  • edit 1 task, fill note field and save
  • delete task instance previously edited
  • task instance deleted

Fix template error when iterating None value and fix params documentation (#31078)

  • Create dag with params
"array_param": Param(
    None,
    type=["null", "array"],
),
  • Click dag's play button, select Trigger DAG w/ config
  • Page loaded without error
  • Form field array_param shown with empty textbox
  • Generated Configuration JSON shows
{
    "array_param": null
}

Fix unmasked env var on task detail view (#31125)

  • Create variable with name contains secret
  • Set environment variable with secret variable in an operator
run_this = BashOperator(
    task_id="masked_envvar",
    bash_command="echo 1",
    env={
        "ENVVAR_NAME": "{{ var.value.secret_service }}"
    },
)
  • Run the dag and open task instance detail page
  • Task Attributes env is masked
env	{'ENVVAR_NAME': '***'}

@ephraimbuddy ephraimbuddy changed the title Status of testing of Apache Airflow 2.6.1rc1 Status of testing of Apache Airflow 2.6.1rc2 May 12, 2023
@ephraimbuddy
Copy link
Contributor Author

Hi @ephraimbuddy , I've just tested #31033, but the DB job still fails due to another circular import. I found a fix for this. Can I directly make a new PR or should I also raise an issue for this?

UPDATE: I've created a PR to fix this #31204 UPDATE 2: #31204 was merged.

Thanks @LipuFei . I have created rc2 with your fix. Verify and let me know how it goes

@potiuk
Copy link
Member

potiuk commented May 13, 2023

Checked PIP/docs to see if missing models are fixed - looks good

@LipuFei
Copy link
Contributor

LipuFei commented May 15, 2023

Hi @ephraimbuddy , I've just tested #31033, but the DB job still fails due to another circular import. I found a fix for this. Can I directly make a new PR or should I also raise an issue for this?
UPDATE: I've created a PR to fix this #31204 UPDATE 2: #31204 was merged.

Thanks @LipuFei . I have created rc2 with your fix. Verify and let me know how it goes

Checked #31033 and #31204 with 2.6.1rc2. Looks good! The migration job can run successfully.

Thanks! @ephraimbuddy

@ephraimbuddy ephraimbuddy changed the title Status of testing of Apache Airflow 2.6.1rc2 Status of testing of Apache Airflow 2.6.1rc3 May 15, 2023
@potiuk
Copy link
Member

potiuk commented May 15, 2023

Tested the #31277 behaviour. Works as expected now:

  1. started airflow

  2. both jobs check and UI show it as live

  3. kill scheduler FORECEFULLY (i.e. with -9)

  4. still alive
    5s

  5. still alive
    10s

  6. still alive
    ....

35 seconds:

The scheduler does not appear to be running. Last heartbeat was received 35 s ago.

Everything as expected

@pankajastro
Copy link
Member

Tested #30921 #30926 #30978 looks good. thanks!

@ephraimbuddy
Copy link
Contributor Author

2.6.1 has been released. Thank you all for testing this release candidate.

@potiuk potiuk added the testing status Status of testing releases label Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

5 participants