Added support for using SHA digest of Docker images.

[elongl]

Closes: #30200.

[boring-cyborg]

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

• Pay attention to the quality of your code (ruff, mypy and type annotations). Our pre-commits will help you with that.
• In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
• Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
• Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
• Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
• Be sure to read the Airflow Coding style.
  Apache Airflow is a community-driven project and together we are making it better 🚀.
  In case of doubts contact the developers at:
  Mailing List: [email protected]
  Slack: https://s.apache.org/airflow-slack

[jedcunningham]

We should also add some tests.

[elongl]

Is there anything else to do for this PR?

[jedcunningham]

Is there anything else to do for this PR?

We should add some test coverage to make sure the default vs "normal" image stuff still works with a digest.

[elongl]

@jedcunningham Care to provide an example for a Helm chart test?
Additionally, what do you think the test case should be?

[potiuk]

@jedcunningham Care to provide an example for a Helm chart test? Additionally, what do you think the test case should be?

The chart tests are here: https://github.com/apache/airflow/tree/main/tests/charts and they are testing if the templates render properly when you provide some config values, so it should be rather straightforward.

[jedcunningham]

Also missing coverage that defaultAirflowDigest works right (hint: I don't think it does).

[ele-elon]

@jedcunningham Sorry, care to clarify what do you mean by that?
I'm a bit confused as defaultAirflowDigest is a constant value.
What is the test-case that needs to be added?

[jedcunningham]

I'm saying that if you set a non-default defaultAirflowDigest and images.useDefaultImageForMigration=True, it doesn't work as it should in the init containers.

It's might be worth having a new test case for it, instead of making that existing parametrized one more complex, see how it goes when you get in there.

[elongl]

Hi @jedcunningham, care to take another look?

[jedcunningham]

@elongl, this looks good. Can you resolve the conflict when you get a chance?

[elongl]

Hi @jedcunningham, thanks for addressing.
Done, resolved the conflicts.

[elongl]

@eladkal @jedcunningham Updated accordingly to the new format.

[boring-cyborg]

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

[jedcunningham]

Thanks @elongl! Congrats on your first commit 🎉

If you'd like, adding support for the digest for the rest of the images would be a good contribution.

[shalberd]

@jedcunningham is there a specific reason to include digest notation for airflow only, not for all the other potential images used? statsd, git-sync, and so on?

[potiuk]

@jedcunningham is there a specific reason to include digest notation for airflow only, not for all the other potential images used? statsd, git-sync, and so on?

No - and feel free to add it.