Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-commit to format chart templates #30546

Open
1 task done
eladkal opened this issue Apr 8, 2023 · 1 comment
Open
1 task done

Add pre-commit to format chart templates #30546

eladkal opened this issue Apr 8, 2023 · 1 comment
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:helm-chart Airflow Helm Chart good first issue kind:task A task that needs to be completed as part of a larger issue

Comments

@eladkal
Copy link
Contributor

eladkal commented Apr 8, 2023

Body

spawn out of #30214 (comment)

Recently we had several PRs to format the chart templates:
#30312
#29941
#29917
However we lack a mechanism to validate that new PRs are complying with the needed format
This task is about researching/finding a way to do it with pre-commit

cc @dnskr

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@eladkal eladkal added good first issue area:helm-chart Airflow Helm Chart kind:task A task that needs to be completed as part of a larger issue labels Apr 8, 2023
@eladkal eladkal added the area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code label Apr 8, 2023
@potiuk
Copy link
Member

potiuk commented Apr 22, 2023

BTW. I could not find a good tool do to such reformatting.

This is as close as I could find for spacing https://github.com/jumanjihouse/pre-commit-hook-yamlfmt but there are more smarts in the manual refactoring.

I think a better solution than reformatting will be flagging bad usages and explaining how to fix them (unless someone would like to add a feature to ruff :) or write an equivalent.

@potiuk potiuk moved this from Backlog to Ready in CI / DEV ENV planned work Nov 30, 2024
@potiuk potiuk moved this from Ready to Backlog in CI / DEV ENV planned work Nov 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-env CI, pre-commit, pylint and other changes that do not change the behavior of the final code area:helm-chart Airflow Helm Chart good first issue kind:task A task that needs to be completed as part of a larger issue
Projects
Status: Backlog
Development

No branches or pull requests

2 participants