Allow Users to disable SwaggerUI via configuration #28354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschuurman
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
msumit
reviewed
Dec 14, 2022
msumit
reviewed
Dec 14, 2022
Due to potential issues we want to give teams the opportunity to disable the swaggerUI. This can now be done via the configuration key: webserver.enable_swagger_ui. For backwards compatibility this has been set to default true, but for teams willing to disable this it can be set to false.
Users can update the code without updating the config file, this would have caused an issue. By implementing the fallback we set a default value. By default the swaggerUI should be enabled
Removing the swagger UI via config should also reflect on the ui, otherwise this change will cause a broken link in the UI
gschuurman
force-pushed
the
feature/disable_swagger_ui
branch
from
1d30cf7 to
76fb463
Compare
Co-authored-by: Ephraim Anierobi <[email protected]>
gschuurman
requested review from
msumit and
ephraimbuddy
and removed request for
ryanahamilton,
ashb,
bbovenzi and
msumit
…vent secret leakage in logs (apache#28239) Co-authored-by: Jarek Potiuk <[email protected]> Co-authored-by: Ash Berlin-Taylor <[email protected]>
Make it a bit more friendly for the next one who release for the first time
The apache#28325 implemented some changes to spellcheck scripts via "isort" - apparently in some cases "docs" is not see as internal package by isort. This needs to be further investigated but this PR restores proper sorting.
* Dont show broken task/run duration * add test
A big restructuring of our docs to make them easier to reason about - in a much more logical and consistent way. Likel other updates and content changes will be needed to make it even better.
Co-authored-by: D. Ferruzzi <[email protected]> Co-authored-by: Niko <[email protected]>
The recent isort changed their mind on sorting the imports. This change follows the change and bumps isort to latest released version (isort has no install_requires on its own so bumping min version has no effect on other dependencies) This change adds a number of isort:skip_file, isort:off, isort:skips in order to handle a very annoying bug in isort, that no matter how much you try, it sometimes treat "known first party" packages differently - depending on how many files it processes at a time. We should be able to restore it after this bug is fixed: PyCQA/isort#2045 This change also updates the common.sql API to skip them from isort for the very same reason (depending on how many files are modified, the isort order might change.
Since we disabled warnings and redirected them to the output file, we lost continuous output of the progress of tests when they were run as `breeze testing tests` command. The whole summary of the tests appeared only at the end of tests. This turned out to be Python output buffering in "filter_out_warning" class. It is fixed by flushing sys.stdout after every printed line now.
Breeze in case of ARM processor lacks support for several components (because they do not have supported ARM binaries available): * MySQL * MSSQL * LevelDB * Azure Service Bus When you try to attempt to run pytest on a group of tests that import one of those, the collection failed and none of the tests could run even if some of them could. This change uses pytest's skip on a module level and local imports in case the tests are inter-mixed with other tests in the same module to avoid import errors during collection. The try/except pattern over pytest.importorskip is preferred because we are using try/except in a number of other cases and we are pretty familiar with similar pattern and importorskipi has a bit unexpected behaviour (it returns imported module and you do not see the usual `import nnnn`. Also in our case we often wrap more than one import in one try/except (and it would lead to a duplicating messages to print really. We also add a separate command in ci to just perform a collection of tests and see if all tests are collectable after uninstalling all those libraries. This would prevent the problems from reapparing. Isort fixes are implemented for recently relesed isort version
Previously, Plyvel had to be disabled in order to get ARM compatibility (it did not have binary wheels released and it failed to compile cleanly on debian). But the last problem is fixed now, so we can re-enable it for ARM.
* Add ensure_ascii=False in trigger dag run api * Fix static checks
gschuurman
requested review from
kaxil,
potiuk,
mik-laj,
eladkal,
jedcunningham,
dstandish and
uranusjr
as code owners
|
@gschuurman plz fix the braking static check and I think it'll be ok to merge. |
msumit
approved these changes
Dec 20, 2022
|
Awesome work, congrats on your first merged pull request! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to potential issues we want to give teams the opportunity to disable the swaggerUI. This can now be done via the configuration key: webserver.enable_swagger_ui.
For backwards compatibility this has been set to default true, but for teams willing to disable this it can be set to false.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.