Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing static checks in main #28401

Merged
merged 1 commit into from
Dec 16, 2022
Merged

Conversation

potiuk
Copy link
Member

@potiuk potiuk commented Dec 16, 2022

The #28325 implemented some changes to spellcheck scripts via "isort" - apparently in some cases "docs" is not see as internal package by isort. This needs to be further investigated but this PR restores proper sorting.


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

The apache#28325 implemented some changes to spellcheck scripts via
"isort" - apparently in some cases "docs" is not see as internal
package by isort. This needs to be further investigated but this
PR restores proper sorting.
@boring-cyborg boring-cyborg bot added area:production-image Production image improvements and fixes kind:documentation labels Dec 16, 2022
@potiuk potiuk merged commit 3bee481 into apache:main Dec 16, 2022
@potiuk potiuk deleted the fix-static-checks branch December 16, 2022 09:37
gschuurman pushed a commit to gschuurman/airflow that referenced this pull request Dec 19, 2022
The apache#28325 implemented some changes to spellcheck scripts via
"isort" - apparently in some cases "docs" is not see as internal
package by isort. This needs to be further investigated but this
PR restores proper sorting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:production-image Production image improvements and fixes kind:documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants