Fix docs build on RTD #12161
Merged
Fix docs build on RTD #12161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
potiuk
requested changes
Nov 7, 2020
mik-laj
commented
Nov 7, 2020
potiuk
approved these changes
Nov 7, 2020
github-actions
bot
added
the
okay to merge
|
The PR is ready to be merged. No tests are needed! |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
mik-laj
commented
Nov 7, 2020
| @@ -608,6 +603,7 @@ def check_spelling() -> None: | |||
| :return: | |||
| """ | |||
| extensions_to_use = [ | |||
| 'provider_init_hack', | |||
There was a problem hiding this comment.
For spell checking, we should also load this plugin.
|
cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs/build_docs.py file is not used by RTD, so we need to use sphinx extensions. I tested this change locally, but didn't test it on RTD.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.