-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves provider packages scripts to dev #12082
Moves provider packages scripts to dev #12082
Conversation
3b6da4f
to
2b9f40c
Compare
Hey @ashb -> the fix to multiple dirs broke automated import check for package provider readme preparation. I fixed it in this PR by moving the scripts to dev and adding few updates. |
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
2b9f40c
to
fbcb9f1
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
a17d864
to
fe52890
Compare
This should hopefully work now. I've added missing setup.py/setup.cfg from the last readme preparation for providers (they have not been committed) and regenerated all the backport providers setup.py's to include "find_namespace_packages" changes. More changes than before so I re-requested review. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
fe52890
to
1cbfa93
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
ed6c81a
to
2850cfd
Compare
Hey @ashb - you might want to take a second look. I actually decided that storing of those setup.py is a terrible idea and I got rid of those. The only remaining ones are READMES/CHANGES but the setup.py are generated dynamically during package generation. |
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
I honestly thought that was what we were doing anyway :D Yay for deleting code. |
Moving to dev/ is a better plan anyway, but this diff:
was how I handled this before -- that cd won't be needed anymore either I don't think. |
Nothing serious left from me -- I will likely be away from computer for most of the weekend now |
0f89a19
to
46d83b3
Compare
All fixed |
46d83b3
to
7246cfe
Compare
The change apache#10806 made airflow works with implicit packages when "airflow" got imported. This is a good change, however it has some unforeseen consequences. The 'provider_packages' script copy all the providers code for backports in order to refactor them to the empty "airflow" directory in provider_packages folder. The apache#10806 change turned that empty folder in 'airflow' package because it was in the same directory as the provider_packages scripts. Moving the scripts to dev solves this problem.
7246cfe
to
40a587d
Compare
All fixed . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll take a look at fixing my minor complaints in a future PR.
The PR needs to run all tests because it modifies core of Airflow! Please rebase it to latest master or ask committer to re-run it! |
A bad rebase in apache#12082 deleted this file by mistake. This missing file was also the cause of needing the documentation to exclude these files Fixes apache#12239
The change #10806 made airflow works with implicit packages
when "airflow" got imported. This is a good change, however
it has some unforeseen consequences. The 'provider_packages'
script copy all the providers code for backports in order
to refactor them to the empty "airflow" directory in
provider_packages folder. The #10806 change turned that
empty folder in 'airflow' package because it was in the
same directory as the provider_packages scripts.
Moving the scripts to dev solves this problem.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.