Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

feat(legacy-plugin-chart-partition): add control panel #470

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
52 commits
Select commit Hold shift + click to select a range
5dc5d23
PR to merge packges for controls migration
May 5, 2020
5efe029
fix: add bootstrap
May 6, 2020
9acf813
fix: change tooltip to tsx
May 6, 2020
bf1296b
fix: types
May 6, 2020
00561e3
fix: tsx error
May 6, 2020
ed63e91
appease linter, enhance a11y
suddjian May 6, 2020
0e6e829
chore(release): publish v0.13.6
rusackas May 6, 2020
3c9ce9e
chore(release): publish v0.13.7
rusackas May 6, 2020
03a9690
Revert "chore(release): publish v0.13.7"
rusackas May 6, 2020
0feb4b7
Revert "chore(release): publish v0.13.6"
rusackas May 6, 2020
8028052
Merge remote-tracking branch 'upstream/master'
rusackas May 6, 2020
20e46d4
chore(release): publish v0.13.7
rusackas May 6, 2020
48bf14b
chore(release): publish v0.13.8
rusackas May 6, 2020
95b7305
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
a96936a
chore(release): publish v0.13.8
rusackas May 6, 2020
6adb225
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
bfcffe0
chore(release): publish v0.13.8
rusackas May 6, 2020
5d83964
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
3ee3357
chore(release): publish v0.13.8
rusackas May 6, 2020
931f0ac
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
aa362fd
chore(release): publish v0.13.8
rusackas May 6, 2020
fab941e
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
a1468c3
chore(release): publish v0.13.8
rusackas May 6, 2020
431eb4d
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
2af55a4
chore(release): publish v0.13.8
rusackas May 6, 2020
6cf4154
Revert "chore(release): publish v0.13.8"
rusackas May 6, 2020
31709b3
Revert "chore(release): publish v0.13.7"
rusackas May 6, 2020
3884368
first stages change for charts
May 6, 2020
186d593
Merge branch 'phillip/SO-264-partitionchart-controls-packages' into p…
May 6, 2020
3fa07d2
addressing PR feedback
suddjian May 6, 2020
dc8cb7e
tweaking bootstrap types
suddjian May 7, 2020
7f27efe
fix test
suddjian May 7, 2020
694c63d
test enter key
suddjian May 7, 2020
8cac2d1
moar tests
suddjian May 7, 2020
c0ce659
code > key
suddjian May 7, 2020
1c4be62
ugh fine
suddjian May 7, 2020
be7a490
chore: more refactor
May 7, 2020
5de2fda
Merge branch 'phillip/SO-264-partitionchart-controls-packages' into p…
May 7, 2020
332a454
Merge branch 'master' of github.com:preset-io/superset-ui
rusackas May 8, 2020
ec4470e
Merge branch 'master' into philip/SO-264pt2-partition-controls-packages
pkdotson May 8, 2020
1ce2e56
fix: merge conflicts
May 8, 2020
6449075
fix merge conflict
May 8, 2020
184e4d9
push change yarn diffs
May 8, 2020
cefaf14
Update plugins/legacy-plugin-chart-partition/src/OptionDescription.jsx
pkdotson May 8, 2020
308aeab
Update OptionDescription.jsx
rusackas May 8, 2020
42e6e63
lint :sparkles:
rusackas May 8, 2020
59a5a35
fix suggestions
May 11, 2020
8f8fd4c
Merge branch 'master' of github.com:preset-io/superset-ui into philip…
May 11, 2020
e0a02ab
Merge branch 'philip/SO-264pt2-partition-controls-packages' of github…
May 11, 2020
b755ff7
Delete optionDescirption.test.jsx
pkdotson May 12, 2020
de05eab
fix: add controller to package
May 12, 2020
6fe58df
mr fix
May 12, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions plugins/legacy-plugin-chart-partition/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,13 @@
"prop-types": "^15.6.2"
},
"peerDependencies": {
"@superset-ui/chart": "^0.13.0",
"@superset-ui/color": "^0.13.0",
"@superset-ui/number-format": "^0.13.0",
"@superset-ui/time-format": "^0.13.0",
"@superset-ui/translation": "^0.13.0"
"@superset-ui/chart": "0.13.3",
"@superset-ui/color": "^0.13.3",
"@superset-ui/control-utils": "^0.13.9",
"@superset-ui/number-format": "^0.13.3",
"@superset-ui/time-format": "^0.13.3",
"@superset-ui/translation": "^0.13.3",
"@superset-ui/validator": "^0.13.3",
"react": "^16.13.1"
}
}
46 changes: 46 additions & 0 deletions plugins/legacy-plugin-chart-partition/src/OptionDescription.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
/**
* Licensed to the Apache Software Foundation (ASF) under one
* or more contributor license agreements. See the NOTICE file
* distributed with this work for additional information
* regarding copyright ownership. The ASF licenses this file
* to you under the Apache License, Version 2.0 (the
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import React from 'react';
pkdotson marked this conversation as resolved.
Show resolved Hide resolved
import PropTypes from 'prop-types';

import { InfoTooltipWithTrigger } from '@superset-ui/control-utils';

const propTypes = {
option: PropTypes.object.isRequired,
};

// This component provides a general tooltip for options
// in a SelectControl
export default function OptionDescription({ option }) {
return (
<span>
<span className="m-r-5 option-label">{option.label}</span>
{option.description && (
<InfoTooltipWithTrigger
className="m-r-5 text-muted"
icon="question-circle-o"
tooltip={option.description}
label={`descr-${option.label}`}
/>
)}
</span>
);
}
OptionDescription.propTypes = propTypes;
Loading