This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 271
feat(legacy-plugin-chart-partition): add control panel #470
Merged
rusackas
merged 52 commits into
apache-superset:master
from
preset-io:philip/SO-264pt2-partition-controls-packages
May 12, 2020
Merged
feat(legacy-plugin-chart-partition): add control panel #470
rusackas
merged 52 commits into
apache-superset:master
from
preset-io:philip/SO-264pt2-partition-controls-packages
May 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3c9ce9e.
This reverts commit 0e6e829.
This reverts commit 48bf14b.
This reverts commit a96936a.
This reverts commit bfcffe0.
This reverts commit 3ee3357.
This reverts commit aa362fd.
This reverts commit a1468c3.
This reverts commit 2af55a4.
This reverts commit 20e46d4.
…hilip/SO-264pt2-partition-controls-packages
Co-authored-by: Evan Rusackas <[email protected]>
rusackas
approved these changes
May 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kristw
reviewed
May 8, 2020
plugins/legacy-plugin-chart-partition/test/optionDescirption.test.jsx
Outdated
Show resolved
Hide resolved
…/SO-264pt2-partition-controls-packages
….com:preset-io/superset-ui into philip/SO-264pt2-partition-controls-packages
Tip: use |
kristw
suggested changes
May 12, 2020
plugins/legacy-plugin-chart-partition/test/OptionDescirption.test.jsx
Outdated
Show resolved
Hide resolved
plugins/legacy-plugin-chart-partition/test/optionDescirption.test.jsx
Outdated
Show resolved
Hide resolved
kristw
changed the title
chore: pt 2 partition controls packages (moving controls to chart)
feat(legacy-plugin-chart-partition): add control panel
May 12, 2020
rusackas
approved these changes
May 12, 2020
kristw
approved these changes
May 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
Pt2 to partition migration. Moving over controls packages.
📜 Documentation
🐛 Bug Fix
🏠 Internal