Add friend UI different (#118)

* 🔄 "Real world testing (#35)

* fix install script

* fix even more install things"
Update anysphere/client commit SHA
🔗 0126583

* 🔄 "add story to public id response
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@6dbadec

* 🔄 "Public identifier (#38)

* implement base58

* implement identifier

* 🔄 "implement identifier
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@15117f2"
Update anysphere/client commit SHA
🔗 67a91f0

* 🔄 "Public identifier (#18)

* add identifier.proto

* implement base58

* implement identifier"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@f8a52a0

* Let the ID of the selectable list be a number or string

* 🔄 "Merge branch 'main' into friends
"
Update anysphere/client commit SHA
🔗 7944dd5

* 🔄 "Merge branch 'main' into friends
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@b4b457d

* 🔄 " Implement friend acking (#21)

* update message.proto with control message

* handle control message properly

* check for ack of control message"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@5cdc265

* 🔄 " Implement friend acking (#41)

* update message.proto with control message

* 🔄 "update message.proto with control message
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@e92e27b

* handle control message properly

* 🔄 "handle control message properly
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@420185b

* check for ack of control message

* 🔄 "check for ack of control message
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@fd692ae

* normal message shall not be control message

* make compile (almost)"
Update anysphere/client commit SHA
🔗 b607bfc

* Async friending schema (#108)

* rename kx_key

* 🔄 "rename kx_key
"
Update anysphere/client commit SHA
🔗 aec1b8b

* rewrite crypto in the new protocol

* 🔄 "rewrite crypto in the new protocol
"
Update anysphere/client commit SHA
🔗 fdcafcd

* 🔄 "rewrite crypto in the new protocol
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@49b488b

* DB change complete

* 🔄 "DB change complete
"
Update anysphere/client commit SHA
🔗 1b6e9bf

* 🔄 "redesign daemon schema
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@96073e4

* 🔄 "fix typo
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@1b0185f

* 🔄 "add story to sync friend request
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@0485f68

* configure server for async requests

* 🔄 "configure server for async requests
"
Update anysphere/client commit SHA
🔗 5b360b9

* 🔄 "configure server for async requests
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@a0458e2

* 🔄 "add public_id to database
"
Update anysphere/client commit SHA
🔗 da589ea

* 🔄 "check point. Most of the code compiles
"
Update anysphere/client commit SHA
🔗 e5d3588

* 🔄 "checkpoint. All programs build
"
Update anysphere/client commit SHA
🔗 757fe13

* checkpoint: rewriting test files

* 🔄 "checkpoint: rewriting test files
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@b60891f

* 🔄 "merge arvid's friend branch
"
Update anysphere/client commit SHA
🔗 75dbc77

* 🔄 "Merge remote-tracking branch 'origin/friends' into async_friending_schema
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@b56fda2

* 🔄 "checkpoint in merging friend
"
Update anysphere/client commit SHA
🔗 1f391d5

* checkpoint in merging friend

* weird bug. debugging

* 🔄 "weird bug. debugging
"
Update anysphere/client commit SHA
🔗 7da1032

* mystery bug resolve. Do not call set_allocated()

* 🔄 "mystery bug resolve. Do not call set_allocated()
"
Update anysphere/client commit SHA
🔗 8b247bd

* 🔄 "checkpoint: another bug
"
Update anysphere/client commit SHA
🔗 2ec90a8

* update workspace

* 🔄 "add linkstatic
"
Update anysphere/client commit SHA
🔗 38ce866

* finally builds correctly

* 🔄 "finally builds correctly
"
Update anysphere/client commit SHA
🔗 46ce1bd

* checkpoint: use standard logging

* 🔄 "checkpoint: use standard logging
"
Update anysphere/client commit SHA
🔗 a90e0b0

* add friend workinggit ca add

* 🔄 "add friend workinggit ca add
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@c64027e

* 🔄 "Merge branch 'friends' into async_friending_schema"
Update anysphere/client commit SHA
🔗 5b23eb9

* 🔄 "Merge remote-tracking branch 'origin/friends' into async_friending_schema
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@45a1a19

* merging friends and async_friend_request

* 🔄 "add outgoing_friend_request
"
Update anysphere/client commit SHA
🔗 e37a115

* fix fast test

* 🔄 "remove comment from crypto'
"
Update anysphere/client commit SHA
🔗 737c86c

* 🔄 "fix bug in crypto
"
Update anysphere/client commit SHA
🔗 65e51dd

* fix bug

* 🔄 "fix bug
"
Update anysphere/client commit SHA
🔗 294d04b

* 🔄 "fix daemonrpc bug
"
Update anysphere/client commit SHA
🔗 9177252

* 🔄 "add identifier
"
Update anysphere/client commit SHA
🔗 2a32e5c

* 🔄 "Merge remote-tracking branch 'origin/async_friending_schema' into async_friending_schema
"
Update anysphere/client commit SHA
🔗 3700ab7

Co-authored-by: Shengtong Zhang <[email protected]>

* 🔄 "Async friending schema (#36)

* rename kx_key

* rewrite crypto in the new protocol

* 🔄 "rewrite crypto in the new protocol
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@49b488b

* DB change complete

* 🔄 "redesign daemon schema
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@96073e4

* 🔄 "fix typo
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@1b0185f

* 🔄 "add story to sync friend request
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@0485f68

* configure server for async requests

* 🔄 "configure server for async requests
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@a0458e2

* add public_id to database

* check point. Most of the code compiles

* checkpoint. All programs build

* checkpoint: rewriting test files

* 🔄 "checkpoint: rewriting test files
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@b60891f

* 🔄 "Merge remote-tracking branch 'origin/friends' into async_friending_schema
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@b56fda2

* checkpoint in merging friend

* weird bug. debugging

* mystery bug resolve. Do not call set_allocated()

* checkpoint: another bug

* update workspace

* add linkstatic

* finally builds correctly

* checkpoint: use standard logging

* add friend workinggit ca add

* 🔄 "add friend workinggit ca add
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@c64027e

* 🔄 "Merge remote-tracking branch 'origin/friends' into async_friending_schema
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@45a1a19

* add outgoing_friend_request

* remove comment from crypto'

* fix bug in crypto

* fix bug

* fix daemonrpc bug

* add identifier

* correct mistake in key exchange

Co-authored-by: Shengtong Zhang <[email protected]>"
Update anysphere/client commit SHA
🔗 4f97e12

* 🔄 "Async friending schema (#22)

* configure server for async requests

* checkpoint: rewriting test files

* add friend workinggit ca add

Co-authored-by: Shengtong Zhang <[email protected]>"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@a0a42dc

* 🔄 "remove rust warning
"
Update anysphere/client commit SHA
🔗 0ebd6d3

* fix tests

* change api

* 🔄 "change api
"
Update anysphere/client commit SHA
🔗 293509d

* update protos

* 🔄 "update protos
"
Update anysphere/client commit SHA
🔗 b518cc0

* add sync test

* 🔄 "add sync test
"
Update anysphere/client commit SHA
🔗 b3c8ddb

* 🔄 "add sync test
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@6f74e52

* 🔄 "push without compile
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@e0bbbc1

* make compile

* 🔄 "make compile
"
Update anysphere/client commit SHA
🔗 3469f6b

* 🔄 "some things only if registered
"
Update anysphere/client commit SHA
🔗 b887016

* use enums instead of integer constants

* 🔄 "use enums instead of integer constants
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@b54435f

* 🔄 "it builds!
"
Update anysphere/client commit SHA
🔗 d7e9c33

* everything builds

* 🔄 "daemon.protoo changes
"
Update anysphere/client commit SHA
🔗 6e6f0b9

* 🔄 "daemon.protoo changes
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@785fc95

* update daemon-js protos

* 🔄 "update daemon-js protos
"
Update anysphere/client commit SHA
🔗 be4c41f

* daemon.proto has been fully sualeh-ified

* 🔄 "daemon.proto has been fully sualeh-ified
"
Update anysphere/client commit SHA
🔗 ef1e014

* add vsls

* async partitions and a basic test passes

* 🔄 "async partitions and a basic test passes
"
Update anysphere/client commit SHA
🔗 ced8449

* 🔄 "async partitions and a basic test passes
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@e32c1b6

* some questions about how to handle name of requests

* 🔄 "update proto. time for disaster to happen. Gooddddd luck
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@778e942

* 🔄 "update protos. We are good.
"
Update anysphere/client commit SHA
🔗 33e39f7

* 🔄 "update protos. We are good.
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@e0d9a9d

* update protos for Invitation Progres

* 🔄 "update protos for Invitation Progres
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@32a45d0

* fix tests

* 🔄 "fix tests
"
Update anysphere/client commit SHA
🔗 8120b25

* replace friend_request -> invitation on server

* 🔄 "replace friend_request -> invitation on server
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@7cf56b7

* added test for people being in different blocks

* 🔄 "added test for people being in different blocks
"
Update anysphere/client commit SHA
🔗 dd95b76

* commit tests

* 🔄 "Merge branch 'friends' into sualeh/add-friend-ui
"
Update anysphere/client commit SHA
🔗 6b4e2d2

* update protos for the ts

* 🔄 "update protos for the ts
"
Update anysphere/client commit SHA
🔗 5673a44

* all relevant APIs for contextBridge are implemented.

* 🔄 "all relevant APIs for contextBridge are implemented.
"
Update anysphere/client commit SHA
🔗 a6bb514

* 🔄 "Friends implementation (#42)

* merge friends

* 🔄 "change to system message
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@4415feb

* make transmitter use the new db types

* finish transmitter changes

* it builds

* 🔄 "it builds
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@209b037

* it builds!

* it builds!

* outgoing async and sync now done

* it builds!

* it builds!

* it builds!

* it builds!

* it builds!

* it builds!

* it builds!

* fix warnings

* add check_rep

* some changes with errors

* make build

* initial tests passing!!!

* 🔄 "initial tests passing!!!
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@cd37145"
Update anysphere/client commit SHA
🔗 3abbdb6

* 🔄 "Friends implementation (#23)

* change to system message

* it builds

* initial tests passing!!!"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@f5f22e7

* 🔄 "fix bug!
"
Update anysphere/client commit SHA
🔗 6a547de

* 🔄 "add more check_rep consistency constraints
"
Update anysphere/client commit SHA
🔗 ab0bdf2

* 🔄 "more checkrep!
"
Update anysphere/client commit SHA
🔗 b72388b

* revamp crypto

* 🔄 "revamp crypto
"
Update anysphere/client commit SHA
🔗 7a2356d

* 🔄 "revamp crypto
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@a156ca9

* 🔄 "add even more check_rep
"
Update anysphere/client commit SHA
🔗 999a256

* 🔄 "more checkrep!!! i love checkrep
"
Update anysphere/client commit SHA
🔗 f7bf199

* 🔄 "Merge remote-tracking branch 'origin/friends' into friends
"
Update anysphere/client commit SHA
🔗 86d93a9

* 🔄 "typescript now has no type errors
"
Update anysphere/client commit SHA
🔗 d1ca953

* 🔄 "many more check rep
"
Update anysphere/client commit SHA
🔗 cd61b82

* 🔄 "add check_rep comment
"
Update anysphere/client commit SHA
🔗 06a7825

* 🔄 "update comment
"
Update anysphere/client commit SHA
🔗 f91ae43

* 🔄 "even more checkreppp
"
Update anysphere/client commit SHA
🔗 bb9c86e

* 🔄 "Merge branch 'friends' into sualeh/add-friend-ui
"
Update anysphere/client commit SHA
🔗 06b0f56

* 🔄 "even more checkrep
"
Update anysphere/client commit SHA
🔗 826873c

* 🔄 "update a TON of dependencies to latest commits.
"
Update anysphere/client commit SHA
🔗 180728d

* add a few anyhow errors

* 🔄 "Merge remote-tracking branch 'origin/friends' into friends
"
Update anysphere/client commit SHA
🔗 dcd6d85

* 🔄 "update daemon_pb.js
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@0b02484

* test passes

* 🔄 "test passes
"
Update anysphere/client commit SHA
🔗 fcb30e4

* 🔄 "rules_proto_grpc doesnt build off master??
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@e8a3578

* 🔄 "story Component
"
Update anysphere/client commit SHA
🔗 05b7b35

* 🔄 "story component update to use numberOfLines
"
Update anysphere/client commit SHA
🔗 13fe103

* update readme

* 🔄 "update readme
"
Update anysphere/client commit SHA
🔗 3ce2f53

* 🔄 "add story command
"
Update anysphere/client commit SHA
🔗 bc3094e

* 🔄 "update with a real story
"
Update anysphere/client commit SHA
🔗 2112930

* 🔄 "different ui
"
Update anysphere/client commit SHA
🔗 5916320

* 🔄 "fix all old UI
"
Update anysphere/client commit SHA
🔗 a255dc7

* 🔄 "reformat
"
Update anysphere/client commit SHA
🔗 a67e68a

* 🔄 "each other
"
Update anysphere/client commit SHA
🔗 aaed08e

* new commits

* 🔄 "add rng
"
Update anysphere/client commit SHA
🔗 83e915e

* 🔄 "add eslint
"
Update anysphere/client commit SHA
🔗 71819e0

* 🔄 "add eslint-react
"
Update anysphere/client commit SHA
🔗 1aaf046

* 🔄 "copy daemon
"
Update anysphere/client commit SHA
🔗 8bb4c9b

* 🔄 "copy schema
"
Update anysphere/client commit SHA
🔗 96df23e

* 🔄 "Merge branch 'main' into add-friend-ui-different"
Update anysphere/client commit SHA
🔗 0feb1ab

* 🔄 "Merge branch 'main' into add-friend-ui-different"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@7017ebe

* 🔄 "fix things
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@6323fdd

* 🔄 "fix things
"
Update anysphere/client commit SHA
🔗 d334c83

* copy over server

* fix integration_tests

* more resets

* remove file

* add newline

* update daemon proto

* 🔄 "update daemon proto
"
Update anysphere/client commit SHA
🔗 69f52e7

* add framer motion

* 🔄 "add framer motion
"
Update anysphere/client commit SHA
🔗 e9ee3bc

* 🔄 "add preliminary animation
"
Update anysphere/client commit SHA
🔗 b8c6dcc

* 🔄 "no blur
"
Update anysphere/client commit SHA
🔗 b09ae37

* 🔄 "big circles
"
Update anysphere/client commit SHA
🔗 eace34c

* 🔄 "small css changes
"
Update anysphere/client commit SHA
🔗 882fd72

* 🔄 "make eslint less annoying
"
Update anysphere/client commit SHA
🔗 f70d401

* 🔄 "fix duration bugs
"
Update anysphere/client commit SHA
🔗 ec875bb

* 🔄 "fully implement addsyncfriend
"
Update anysphere/client commit SHA
🔗 d535a91

* 🔄 "initial async page
"
Update anysphere/client commit SHA
🔗 52225fe

* 🔄 "able to send to outgoing friend in the UI
"
Update anysphere/client commit SHA
🔗 8757dd9

* 🔄 "remove autofocus
"
Update anysphere/client commit SHA
🔗 3030ec7

* add add gui cmd

* 🔄 "add add gui cmd
"
Update anysphere/client commit SHA
🔗 c99e2ac

* npm install

* fix db problems

* 🔄 "fix db problems
"
Update anysphere/client commit SHA
🔗 62315f3

* fix streaming problems and add a regression test

* fix the streaming test finally!

* 🔄 "fix streaming problems and add a regression test
"
Update anysphere/client commit SHA
🔗 f89f4b6

* the death test finally works

* 🔄 "remove todo
"
Update anysphere/client commit SHA
🔗 33e39cc

* 🔄 "fix type problems
"
Update anysphere/client commit SHA
🔗 b2e0592

* 🔄 "fix the UI
"
Update anysphere/client commit SHA
🔗 5a3a345

* 🔄 "run trunk fmt
"
Update anysphere/client commit SHA
🔗 4bf9547

* 🔄 "clean up preload
"
Update anysphere/client commit SHA
🔗 51e2e69

* 🔄 "fix the type of the daemon api in preload.ts
"
Update anysphere/client commit SHA
🔗 7381fb5

* 🔄 "use registerUser not register
"
Update anysphere/client commit SHA
🔗 259dbea

* 🔄 "fix access key form box
"
Update anysphere/client commit SHA
🔗 901e61e

* 🔄 "fix missing return type
"
Update anysphere/client commit SHA
🔗 9fcfa1e

* 🔄 "fix more eslint errors
"
Update anysphere/client commit SHA
🔗 e55275d

* 🔄 "add update-rust-project script
"
Update anysphere/client commit SHA
🔗 214ed0a

* 🔄 "busy timeout!
"
Update anysphere/client commit SHA
🔗 ac3be62

* 🔄 "fix trunk fmt
"
Update anysphere/asphr commit SHA
🔗 anysphere/asphr@6ccc8a4

* 🔄 "getcolor string
"
Update anysphere/client commit SHA
🔗 9b701ca

* 🔄 "remove trunk linters
"
Update anysphere/client commit SHA
🔗 23b8037

* 🔄 "explain animations
"
Update anysphere/client commit SHA
🔗 a4666e2

* 🔄 "add comment:
"
Update anysphere/client commit SHA
🔗 c637d1d

* 🔄 "add seed log
"
Update anysphere/client commit SHA
🔗 b56b149

* 🔄 "sort the array
"
Update anysphere/client commit SHA
🔗 fd98b5f

* 🔄 "fix spaces between sentences
"
Update anysphere/client commit SHA
🔗 3b6eefe

* 🔄 "remove stupid at most 1 friend debugging thing
"
Update anysphere/client commit SHA
🔗 3b43922

* 🔄 "refactor the story list component
"
Update anysphere/client commit SHA
🔗 3506557

* 🔄 "add unimplemented method
"
Update anysphere/client commit SHA
🔗 c1386a0

* 🔄 "remove legacy friend
"
Update anysphere/client commit SHA
🔗 0ce5826

Co-authored-by: Sualeh Asif <[email protected]>
Co-authored-by: Shengtong Zhang <[email protected]>
Co-authored-by: Sualeh Asif <[email protected]>

.bazelrc

@@ -29,11 +29,11 @@ build --repo_env=RULES_RUST_TOOLCHAIN_INCLUDE_RUSTC_SRCS=true
 try-import %workspace%/.user.bazelrc
 
 # setting up remote caching
-# build --bes_results_url=https://app.buildbuddy.io/invocation/
-# build --bes_backend=grpcs://remote.buildbuddy.io
-# build --remote_cache=grpcs://remote.buildbuddy.io
-# build --remote_upload_local_results
-# build --remote_timeout=3600
+#build --bes_results_url=https://app.buildbuddy.io/invocation/
+#build --bes_backend=grpcs://remote.buildbuddy.io
+#build --remote_cache=grpcs://remote.buildbuddy.io
+#build --remote_upload_local_results
+#build --remote_timeout=3600
 # build --experimental_remote_cache_compression
 # build --experimental_remote_cache_async
 # build --remote_download_toplevel

WORKSPACE

@@ -7,7 +7,7 @@ load("@bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")
 
 git_repository(
     name = "asphr",
-    commit = "27c4710f38add042030e01867c3e0a6f8a8199a3",  # autoupdate anysphere/asphr
+    commit = "6ccc8a4cf8502de4a6d78beaf34f833d4bec598e",  # autoupdate anysphere/asphr
     init_submodules = True,
     remote = "https://github.com/anysphere/asphr.git",
 )
@@ -39,7 +39,7 @@ setup_asphr("@asphr")
 
 git_repository(
     name = "client",
-    commit = "b014cf1c7e62c4896c5d4d3600f9cff31cd7ec27",  # autoupdate anysphere/client
+    commit = "0ce5826883bcc9b4dd7956091bd3bf0d19970e34",  # autoupdate anysphere/client
     init_submodules = True,
     remote = "https://github.com/anysphere/client.git",
 )

integration_tests/daemon_tests/daemon_stream_messages_test.cc

@@ -3,6 +3,61 @@
 namespace asphr::testing {
 namespace {
 
+using DaemonRpcDeathTest = DaemonRpcTest;
+
+// regression test
+TEST_F(DaemonRpcDeathTest, StreamMessagesWithoutAnyMessages) {
+  ResetStub();
+
+  GTEST_FLAG_SET(death_test_style, "threadsafe");
+
+  ASSERT_DEATH(
+      {
+        auto v = register_people(1);
+        auto friend1 = std::move(v.at(0));
+
+        const int rpc1_port = absl::Uniform(bitgen_, 10'000, 65'000);
+        std::ostringstream rpc1_addr;
+        rpc1_addr << "localhost:" << rpc1_port;
+        grpc::ServerBuilder builder;
+        builder.AddListeningPort(rpc1_addr.str(),
+                                 grpc::InsecureServerCredentials());
+        builder.RegisterService(&(*friend1.rpc));
+        auto rpc1_server = builder.BuildAndStart();
+        std::shared_ptr<grpc::Channel> rpc1_channel = grpc::CreateChannel(
+            rpc1_addr.str(), grpc::InsecureChannelCredentials());
+        auto rpc1_stub = asphrdaemon::Daemon::NewStub(rpc1_channel);
+
+        auto did_unblock = false;
+
+        // launch a thread
+        std::thread t([&]() {
+          GetMessagesRequest request;
+          request.set_filter(GetMessagesRequest::ALL);
+          grpc::ClientContext context;
+          auto stream = rpc1_stub->GetMessagesStreamed(&context, request);
+          GetMessagesResponse response;
+          stream->Read(&response);
+          stream->Read(&response);
+          did_unblock = true;
+        });
+        cout << "waiting for thread to block" << endl;
+
+        // wait for 5 seconds
+        std::this_thread::sleep_for(std::chrono::seconds(5));
+        if (did_unblock) {
+          // bad case — the thread is not stalling, which is very very bad...
+          // there are no messages so we shouldn't receive any messages!!
+          t.join();
+          return;
+        } else {
+          // good case — the thread is stalling, which is just what we want!
+          std::terminate();
+        }
+      },
+      "");
+}
+
 TEST_F(DaemonRpcTest, StreamMessages) {
   ResetStub();