use enums instead of integer constants

anysphere · Jun 28, 2022 · b54435f · b54435f
1 parent e0bbbc1
commit b54435f
Showing 1 changed file with 15 additions and 6 deletions.
diff --git a/schema/daemon.proto b/schema/daemon.proto
@@ -18,8 +18,9 @@ service Daemon {
 
     rpc GetFriendList(GetFriendListRequest) returns (GetFriendListResponse) {}
 
-    rpc GetPublicID(GetPublicIDRequest) returns (GetPublicIDResponse) {}
+    rpc GetMyPublicID(GetMyPublicIDRequest) returns (GetMyPublicIDResponse) {}
 
+    // use for in-person key exchange
     rpc AddSyncFriend(AddSyncFriendRequest) returns (AddSyncFriendResponse) {}
 
     rpc AddAsyncFriend(AddAsyncFriendRequest) returns (AddAsyncFriendResponse) {}
@@ -62,20 +63,26 @@ message RegisterUserResponse {}
 
 message GetFriendListRequest {}
 
+enum FriendRequestProgress {
+    Incoming = 0;
+    OutgoingAsync = 1;
+    OutgoingSync = 2;
+    Complete = 3;
+}
 message FriendInfo {
     string unique_name = 1;
     string display_name = 2;
     string public_id = 3;
-    int32 progress = 4;
+    FriendRequestProgress request_progress = 4;
 }
 
 message GetFriendListResponse {
     repeated FriendInfo friend_infos = 1;
 }
 
-message GetPublicIDRequest {}
+message GetMyPublicIDRequest {}
 
-message GetPublicIDResponse {
+message GetMyPublicIDResponse {
     string public_id = 1;
     string story = 2; // en encoding of the public identifier in a nice story format
 }
@@ -89,8 +96,10 @@ message AddSyncFriendRequest {
 message AddSyncFriendResponse {}
 
 message AddAsyncFriendRequest {
-    FriendInfo friend_info = 1;
-    string message = 2;
+    string unique_name = 1;
+    string display_name = 2;
+    string public_id = 3;
+    string message = 4;
 }
 
 message AddAsyncFriendResponse {}