Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change toService.scope to enum #4562

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Change toService.scope to enum #4562

merged 1 commit into from
Jan 19, 2023

Conversation

GraysonWu
Copy link
Contributor

Signed-off-by: graysonwu [email protected]

@GraysonWu
Copy link
Contributor Author

/test-multicluster-e2e

@codecov
Copy link

codecov bot commented Jan 17, 2023 •
edited
Loading

Codecov Report

Merging #4562 (7f2ce95) into main (8961420) will decrease coverage by 0.07%.
The diff coverage is 77.77%.

❗ Current head 7f2ce95 differs from pull request most recent head 9110456. Consider uploading reports for the commit 9110456 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4562      +/-   ##
==========================================
- Coverage   68.51%   68.45%   -0.07%     
==========================================
  Files         400      412      +12     
  Lines       58216    58209       -7     
==========================================
- Hits        39887    39845      -42     
- Misses      15564    15599      +35     
  Partials     2765     2765
Flag Coverage Δ *Carryforward flag
e2e-tests 61.98% <ø> (+23.64%) ⬆️
integration-tests 34.52% <ø> (-0.04%) ⬇️ Carriedforward from 9110456
kind-e2e-tests 47.22% <63.88%> (-0.25%) ⬇️ Carriedforward from 9110456
unit-tests 57.56% <18.05%> (+<0.01%) ⬆️ Carriedforward from 9110456

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
cmd/antrea-agent/options.go 36.47% <ø> (ø)
pkg/config/flowaggregator/default.go 100.00% <ø> (ø)
pkg/flowaggregator/exporter/ipfix.go 63.11% <50.00%> (ø)
pkg/agent/flowexporter/exporter/exporter.go 81.68% <74.35%> (+1.48%) ⬆️
pkg/flowaggregator/certificate.go 75.52% <81.48%> (ø)
pkg/agent/flowexporter/exporter/certificate.go 50.00% <100.00%> (ø)
pkg/agent/util/ethtool/ethtool_linux.go 0.00% <0.00%> (-70.00%) ⬇️
...gent/controller/noderoute/node_route_controller.go 57.43% <0.00%> (-6.32%) ⬇️
pkg/agent/controller/trafficcontrol/controller.go 77.24% <0.00%> (-5.55%) ⬇️
... and 61 more

@luolanzone luolanzone added the area/multi-cluster Issues or PRs related to multi cluster. label Jan 17, 2023
luolanzone
luolanzone reviewed Jan 17, 2023
View reviewed changes
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
multicluster/test/e2e/service_test.go Outdated Show resolved Hide resolved
@luolanzone luolanzone requested a review from Dyanngg January 17, 2023 07:05
@GraysonWu
Copy link
Contributor Author

/test-multicluster-e2e

luolanzone
luolanzone approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@luolanzone luolanzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luolanzone
Copy link
Contributor

The impacted e2e test testANPToServices is passed in jenkins. I think the failed MC e2e is caused by known issue which will be fixed by #4547. @GraysonWu could you double check?
@jianjuns @Dyanngg could you review this PR? I think this need to be back-ported to v1.10 along with #4555. I will cherry-pick this change when it's merged, thanks.

@jianjuns
Copy link
Contributor

/test-all

@jianjuns
Copy link
Contributor

This change should be back-port to 1.10 patch.

@GraysonWu
Copy link
Contributor Author

The impacted e2e test testANPToServices is passed in jenkins. I think the failed MC e2e is caused by known issue which will be fixed by #4547. @GraysonWu could you double check? @jianjuns @Dyanngg could you review this PR? I think this need to be back-ported to v1.10 along with #4555. I will cherry-pick this change when it's merged, thanks.

Yes, you are right.

@GraysonWu GraysonWu mentioned this pull request Jan 17, 2023
Merged
@GraysonWu
Copy link
Contributor Author

/test-multicluster-e2e

@jianjuns jianjuns merged commit da6ca96 into antrea-io:main Jan 19, 2023
luolanzone pushed a commit to luolanzone/antrea that referenced this pull request Jan 20, 2023
@GraysonWu @luolanzone
Change ANP/ACNP toService.scope to enum (antrea-io#4562)
d510cb6 
Signed-off-by: graysonwu <[email protected]>
jianjuns pushed a commit that referenced this pull request Jan 20, 2023
@luolanzone
Automated cherry pick of #4543 and #4562 (#4555)
7b522eb 
* Update YAMLs and docs about Multi-cluster NetworkPolicy

Signed-off-by: Jianjun Shen <[email protected]>

* Change ANP/ACNP toService.scope to enum (#4562)

Signed-off-by: graysonwu <[email protected]>
GraysonWu added a commit to GraysonWu/antrea that referenced this pull request Jan 27, 2023
@GraysonWu
Change ANP/ACNP toService.scope to enum (antrea-io#4562)
b141177 
Signed-off-by: graysonwu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jianjuns jianjuns jianjuns approved these changes

@luolanzone luolanzone luolanzone approved these changes

@Dyanngg Dyanngg Awaiting requested review from Dyanngg

Assignees
No one assigned
Labels
area/multi-cluster Issues or PRs related to multi cluster.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GraysonWu @luolanzone @jianjuns