Add ServiceLocalToRemote reject type #4547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/test-multicluster-e2e |
Codecov Report
@@ Coverage Diff @@
## main #4547 +/- ##
==========================================
+ Coverage 68.31% 69.81% +1.50%
==========================================
Files 400 414 +14
Lines 58324 58454 +130
==========================================
+ Hits 39843 40812 +969
+ Misses 15708 14851 -857
- Partials 2773 2791 +18
*This pull request uses carry forward flags. Click here to find out more.
|
Dyanngg
reviewed
Jan 11, 2023
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
f2434d8 to
12e8802
Compare
|
/test-multicluster-e2e |
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
12e8802 to
25de3db
Compare
|
/test-multicluster-e2e |
luolanzone
reviewed
Jan 17, 2023
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
25de3db to
ed31e58
Compare
|
/test-multicluster-e2e |
|
/test-all |
|
/test-multicluster-e2e |
luolanzone
reviewed
Jan 30, 2023
GraysonWu
force-pushed
the
fix-snp-rej
branch
2 times, most recently
from
f943287 to
f5072ae
Compare
|
/test-multicluster-e2e |
Dyanngg
previously approved these changes
Feb 6, 2023
luolanzone
previously approved these changes
Feb 7, 2023
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
f5072ae to
c5f1249
Compare
|
/test-multicluster-e2e |
|
/test-all |
jianjuns
reviewed
Feb 10, 2023
Signed-off-by: graysonwu <[email protected]>
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
c5f1249 to
dcfd780
Compare
jianjuns
previously approved these changes
Feb 14, 2023
|
@GraysonWu the unit test diff coverage is 0, could you check if possible to add some unit tests? thanks. |
|
/test-multicluster-e2e |
|
/test-all |
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
55c1cae to
f9f8e81
Compare
|
/test-all |
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
f9f8e81 to
f69c50d
Compare
GraysonWu
force-pushed
the
fix-snp-rej
branch
from
f69c50d to
a8871af
Compare
Signed-off-by: graysonwu <[email protected]>
|
/test-all |
|
@jianjuns could you help to take a look again? @GraysonWu added a few unit tests for the change. |
tnqn
pushed a commit
that referenced
this pull request
Apr 7, 2023
…4819) Signed-off-by: graysonwu <[email protected]>
jainpulkit22
pushed a commit
to urharshitha/antrea
that referenced
this pull request
Apr 28, 2023
For single cluster rejection, there is no difference for Service traffic or Pod-to-Pod traffic in localToRemote rejection. Service LB won't be executed on the Node where we generate reject responses. So we didn't define podLocalToRemote and serviceLocalToRemote and just let the reject response packet start from L3/L2Forwarding table based on the Node type. But in multi-cluster situations, when the server Endpoint Pod is on the gateway Node of its cluster, where Service LB is executed, we need reject response packets to go thru the whole pipeline to be correctly UnDNATed and forwarded.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4535
For single cluster rejection, there is no difference for Service traffic or Pod-to-Pod traffic in
localToRemoterejection. Service LB won't be executed on the Node where we generate reject responses. So we didn't definepodLocalToRemoteandserviceLocalToRemoteand just let the reject response packet start from L3/L2Forwarding table based on the Node type.But in multi-cluster situations, when the server Endpoint Pod is on the gateway Node of its cluster, where Service LB is executed, we need reject response packets to go thru the whole pipeline to be correctly UnDNATed and forwarded.
Signed-off-by: graysonwu [email protected]