Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: revert Menu easing functions #27651

Merged
merged 1 commit into from
Nov 10, 2020
Merged

style: revert Menu easing functions #27651

merged 1 commit into from
Nov 10, 2020

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Nov 9, 2020

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

#27565 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/menu/index.en-US.md
View rendered components/menu/index.zh-CN.md
View rendered components/select/demo/search-sort.md
View rendered components/select/index.en-US.md
View rendered components/select/index.zh-CN.md
View rendered docs/react/i18n.en-US.md
View rendered docs/react/i18n.zh-CN.md

@afc163 afc163 changed the base branch from master to feature November 9, 2020 07:19
@afc163
Copy link
Member Author

afc163 commented Nov 9, 2020

@jljsj33 就是 css 体积会大一点。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Nov 9, 2020

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 9, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 77f33b2:

Sandbox Source
antd reproduction template Configuration

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2020

Size Change: +839 B (0%)

Total Size: 791 kB

Filename Size Change
./dist/antd-with-locales.min.js 314 kB +1.38 kB (0%)
./dist/antd.compact.min.css 66.1 kB -223 B (0%)
./dist/antd.dark.min.css 67.4 kB -237 B (0%)
./dist/antd.min.css 66.1 kB -224 B (0%)
./dist/antd.min.js 277 kB +147 B (0%)

compressed-size-action

@afc163
Copy link
Member Author

afc163 commented Nov 9, 2020

argos 慢一拍:https://www.argos-ci.com/ant-design/ant-design/builds/367 里显示的其实是 #27650 的结果。

@yoyo837
Copy link
Contributor

yoyo837 commented Nov 9, 2020

argos 慢一拍:https://www.argos-ci.com/ant-design/ant-design/builds/367 里显示的其实是 #27650 的结果。

@shaodahong

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #27651 (77f33b2) into feature (5724a8b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           feature    #27651   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          393       393           
  Lines         7412      7412           
  Branches      2042      2042           
=========================================
  Hits          7412      7412           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5724a8b...77f33b2. Read the comment docs.

@shaodahong
Copy link
Member

/rebase

@afc163
Copy link
Member Author

afc163 commented Nov 10, 2020

来个 approve

@afc163 afc163 merged commit 8a3e271 into feature Nov 10, 2020
@afc163 afc163 deleted the revert-menu-easing branch November 10, 2020 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants