-
-
Notifications
You must be signed in to change notification settings - Fork 50.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Menu support expandIcon #27565
Conversation
fe934a1
to
0c9b52b
Compare
Size Change: -961 B (0%) Total Size: 790 kB
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit db17b9c:
|
Codecov Report
@@ Coverage Diff @@
## feature #27565 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 389 389
Lines 7404 7404
Branches 2087 2038 -49
=========================================
Hits 7404 7404
Continue to review full report at Codecov.
|
components/style/themes/default.less
Outdated
@@ -539,7 +539,7 @@ | |||
@menu-collapsed-width: 80px; | |||
@menu-bg: @component-background; | |||
@menu-popup-bg: @component-background; | |||
@menu-item-color: @text-color; | |||
@menu-item-color: #555; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个暗色主题下会不会有问题?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
有道理,我检查一下。
我觉得你缓动可以不用改,,默认缓动很平庸。。。 |
* style: optimize menu expand icon color close #20035 * feat: 🆕 support Menu expandIcon * revert arrow color
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #20035
💡 Background and solution
📝 Changelog
expandIcon
, and optimize default expand icon style.expandIcon
属性以支持自定义展开图标,同时优化了默认图标的样式。☑️ Self Check before Merge
View rendered components/menu/index.en-US.md
View rendered components/menu/index.zh-CN.md