Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating CORBA and Python 3.8 #2517

Merged
merged 17 commits into from
Nov 30, 2023
Merged

Deprecating CORBA and Python 3.8 #2517

merged 17 commits into from
Nov 30, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Nov 21, 2023 •
edited
Loading

As the title.

Close #2242
Close #2138

@ansys-reviewer-bot
Copy link
Contributor

Thanks for opening a Pull Request. If you want to perform a review write a comment saying:

@ansys-reviewer-bot review

@germa89 germa89 mentioned this pull request Nov 21, 2023
Closed
4 tasks
@germa89 germa89 requested a review from clatapie November 21, 2023 10:45
@germa89 germa89 self-assigned this Nov 21, 2023
@germa89 germa89 added Maintenance CI/CD Related with CICD, Github Actions, etc labels Nov 21, 2023
@germa89 germa89 requested a review from koubaa November 21, 2023 10:45
@germa89 germa89 requested a review from RobPasMue November 21, 2023 10:57
RobPasMue
RobPasMue approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so happy to see deprecation of corba and Python 3.8... ❤️

@germa89 germa89 mentioned this pull request Nov 21, 2023
Closed
2 tasks
@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Merging #2517 (27d4149) into main (e90c753) will increase coverage by 5.86%.
Report is 1 commits behind head on main.
The diff coverage is 55.55%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2517      +/-   ##
==========================================
+ Coverage   76.67%   82.54%   +5.86%     
==========================================
  Files          44       44              
  Lines        9047     9040       -7     
==========================================
+ Hits         6937     7462     +525     
+ Misses       2110     1578     -532

@germa89
Copy link
Collaborator Author

germa89 commented Nov 21, 2023

Let's forget about the coverage on this one.

@germa89 germa89 mentioned this pull request Nov 21, 2023
Closed
2 tasks
clatapie
clatapie approved these changes Nov 27, 2023
View reviewed changes
Copy link
Contributor

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clatapie clatapie requested a review from a team as a code owner November 27, 2023 17:23
@germa89 germa89 enabled auto-merge (squash) November 29, 2023 17:23
@germa89 germa89 merged commit 0a4287e into main Nov 30, 2023
25 of 26 checks passed
@germa89 germa89 deleted the feat/deprecating-corba-interface branch November 30, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clatapie clatapie clatapie approved these changes

@RobPasMue RobPasMue RobPasMue approved these changes

@koubaa koubaa koubaa approved these changes

Assignees

@germa89 germa89

Labels
CI/CD Related with CICD, Github Actions, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python maintenance Deprecate CORBA interface
4 participants
@germa89 @koubaa @RobPasMue @clatapie