Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python maintenance #2242

Closed
3 of 4 tasks
germa89 opened this issue Aug 11, 2023 · 10 comments · Fixed by #2517
Closed
3 of 4 tasks

Python maintenance #2242

germa89 opened this issue Aug 11, 2023 · 10 comments · Fixed by #2517
Assignees

Comments

@germa89
Copy link
Collaborator

germa89 commented Aug 11, 2023

Following Numpy and Sphinx, I think we should consider to deprecate Python 3.8.

The action list should be:

The deprecation warning won't be a deprecation per se. It will be a "drop support" message. I am not planning to force users to have a minimum Python version.

Ping @RobPasMue @jorgepiloto @koubaa for feedback.

@germa89 germa89 self-assigned this Aug 11, 2023
@germa89
Copy link
Collaborator Author

germa89 commented Aug 11, 2023

@germa89
Copy link
Collaborator Author

germa89 commented Aug 11, 2023

/remind me to work on this in 4 hours

@reminders reminders bot added the reminder label Aug 11, 2023
@reminders
Copy link

reminders bot commented Aug 11, 2023

@germa89 set a reminder for Aug 11th 2023

@github-actions github-actions bot removed the reminder label Aug 11, 2023
@RobPasMue
Copy link
Member

Python 3.8 is +1 year away from EOL... Is there any kind of code specific for Python 3.8 on your library that you want to get rid of right now?... Following our previous approach, I think we should wait until the Ansys Unified Install decides to deprecate it... As we did with Python 3.7. Though I think Python 3.8 is not shipped with it. They jumped to Python 3.10 AFAIK.

Anyway... I'd avoid it, at least for now.

@RobPasMue
Copy link
Member

FYI - I agree on using 3.10 as default. Even 3.11 at this point!

@germa89
Copy link
Collaborator Author

germa89 commented Aug 12, 2023

Anyway... I'd avoid it, at least for now.

I didn't get it. You will avoid to deprecate it?

The plan is to "stop supporting it" with 0.67, which might come in months at the current release level. Very likely in 2024.

@RobPasMue
Copy link
Member

Yes, I'd avoid deprecating Python 3.8 right now. You can announce deprecation "a few months" before actually dropping its support, but with +1 year still of life, my opinion is that it is too soon to start deprecating it. But again, that's just my POV - feel free to deprecate it if you prefer!

@germa89
Copy link
Collaborator Author

germa89 commented Aug 12, 2023

Yes, I'd avoid deprecating Python 3.8 right now. You can announce deprecation "a few months" before actually dropping its support, but with +1 year still of life, my opinion is that it is too soon to start deprecating it. But again, that's just my POV - feel free to deprecate it if you prefer!

You are right. I will wait for the EOL to deprecate it.

@germa89
Copy link
Collaborator Author

germa89 commented Aug 12, 2023

Furthermore, it seems that Python 3.12 is not yet officially release.. So better wait on deprecating 3.8.

@RobPasMue
Copy link
Member

See #2507 - vtk 9.3.0 supports Python 3.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants