Fix respawning of pool instances have different names #2493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2493 +/- ##
==========================================
- Coverage 82.15% 80.10% -2.05%
==========================================
Files 46 46
Lines 9115 9118 +3
==========================================
- Hits 7488 7304 -184
- Misses 1627 1814 +187 |
germa89
commented
Nov 20, 2023
Getting back the name/thread_name argument to pool_monitor_thread
…ub.com/pyansys/pymapdl into fix/pool-names-changes-when-respawning
|
Leaving this PR for next week because I need a machine with MAPDL installed. |
|
I'm merging because we cannot really test pool library in the pull requests (because we ran student which does not support more than one MAPDL instance) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The re-spawning of pool instances was creating instances with different names.
Close #2453