Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky tests #2435

Open
1 of 3 tasks
germa89 opened this issue Oct 19, 2023 · 2 comments
Open
1 of 3 tasks

Flaky tests #2435

germa89 opened this issue Oct 19, 2023 · 2 comments

Comments

@germa89
Copy link
Collaborator

germa89 commented Oct 19, 2023 •
edited
Loading

To fix one day...

  • test_heal test_heal is flaky #2173

    [FAILED] test_heal - E       AttributeError: 'NoneType' object has no attribute 'exit'

  • test_empty_mesh. From: 1c5b3a1

    [FAILED] test_empty_mesh - E           ansys.mapdl.core.errors.MapdlConnectionError: The channel is not alive.

  • test_plot_incomplete_nodal_selection. Regression image fail. Related to Improve plotting quality #2301
    image

    From f535d6e
@germa89 germa89 mentioned this issue Oct 25, 2023
Merged
@germa89 germa89 added the BUG label Jan 12, 2024
@github-actions github-actions bot removed the BUG label Jun 18, 2024
@germa89 germa89 pinned this issue Jul 12, 2024
@germa89
Copy link
Collaborator Author

germa89 commented Jul 12, 2024 •
edited
Loading

Adding because of #3266 :

  • test_launch_mapdl_cli_list. It does not seems to detect the running MAPDL. 
     AssertionError: assert ('running' in 'Name    Is Instance    Status    gRPC port    PID\n------  -------------  --------  -----------  -----\n' or 'sleeping' in 'Name    Is Instance    Status    gRPC port    PID\n------  -------------  --------  -----------  -----\n')
  • test_map_timeout. Probably there is a lag in some of the threads which makes one of the instances not being killed on time.
  • test__remove_temp_dir_on_exit. Because there is another MAPDL instance running, probably the test before this one (test__remove_temp_dir_on_exit) left the instance behind.
  • test_remove_temp_dir_on_exit. Same as before.
  • Additionally, I know some instances are left alive after each testing. I should check/activate run_before_and_after_tests_3 fixture.

germa89 added a commit that referenced this issue Jul 12, 2024
@germa89
test: skip flaky test. See #2435 comment
d99d916
@germa89
Copy link
Collaborator Author

germa89 commented Jul 12, 2024

Test heal is not flaky anymore since #2493

@germa89 germa89 mentioned this issue Jul 12, 2024
Merged
10 tasks
germa89 added a commit that referenced this issue Jul 12, 2024
@germa89 @pyansys-ci-bot
fix: pool issues (#3266)
2df6130 
* feat: adding port to exception message

* fix: attempt tests before being ready

* feat: changing arguments order

* chore: wait for complete exit

* test: raise exception if mapdl instances are alive between tests

* chore: adding changelog file 3257.added.md

* fix: adding missing import

* fix: adding missing object

* test: check process status

* fix: running process check only on local.

* feat: enforcing having exactly the amount of instances specified.
Adding timeout to check if the instance is already launched.

* feat: adding a timeout before moving on

* fix: latest_version env var

* feat: added pool_creator fixture. We use pool fixture to check pool health.
fix: some tests

* fix: NoSuchProcess error. Small cosmetic fix

* chore: adding changelog file 3266.fixed.md

* chore: adding changelog file 3266.fixed.md

* refactor: small reog

* test: activating previously skipped tests

* fix: test

* fix: adding port to avoid port collision

* fkix: tests

* docs: adding comments

* feat: adding ``ready`` property and ``wait_for_ready`` method.
fix: Making sure we restart the instance on the same path.
refactor: waiting for the instance to get ready.
test: added test to check directory names when there is a restart.

* feat: Checking ports from the cmdline

* fix: tests

* fix: early exit in process check to avoid accessdenied.

* Revert "fkix: tests"

This reverts commit d58971b.

* feat: catching already dead process.

* fix: pymapdl list not showing any instance because name method wasn't called.

* feat: wrapping process checking in a try/except to avoid calling already dead process

* feat: using dynamic port in test_cli. Starting and stopping another instance.

* fix: test

* refactor: reducing code duplicity

* feat: making sure we stop MAPDL if failure

* fix: test_remove_temp_dir_on_exit on windows

* test: without rerun

* ci: using v24.2 for docs building

* fix: exception in list instance processing

* feat: using PORT1 variable
refactor: moving console test to test_console

* fix: tests

* ci: run all tests

* test: testing

* test: no raise exception.

* ci: increasing timeout for local and min jobs

* chore: adding logging statements.

* test: marking tests as xfail

* ci: adding back pytest config

* Revert "build: update ansys-api-mapdl to 0.5.2 (#3255)"

This reverts commit 0bcf344.

* test: skip flaky tests

* build: update ansys-api-mapdl to 0.5.2 (#3255)

* build: update ansys-api-mapdl to 0.5.2

* chore: adding changelog file 3255.dependencies.md

---------

Co-authored-by: pyansys-ci-bot <[email protected]>

* test: skip flaky test. See #2435 comment

* fix: not showing instances on linux (#3263)

* fix: not showing instances on linux

* chore: adding changelog file 3263.fixed.md

---------

Co-authored-by: pyansys-ci-bot <[email protected]>

* ci: undo some stuff

* test: adding some waiting time after attempting to kill instance.

* fix: missing import.

* chore: remove fragment from other PR.

---------

Co-authored-by: pyansys-ci-bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@germa89