Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactivating macOS workflow #147

Merged
merged 18 commits into from
Aug 4, 2022
Merged

Reactivating macOS workflow #147

merged 18 commits into from
Aug 4, 2022

Conversation

RobPasMue
Copy link
Member

Resolves #146

@RobPasMue RobPasMue linked an issue Aug 1, 2022 that may be closed by this pull request
@RobPasMue
Copy link
Member Author

Not going to work off-the-shelf. Would require some work.

@RobPasMue RobPasMue marked this pull request as ready for review August 2, 2022 07:46
@RobPasMue RobPasMue requested review from akaszynski and germa89 August 2, 2022 07:46
@RobPasMue RobPasMue self-assigned this Aug 2, 2022
@RobPasMue
Copy link
Member Author

PR ready for review @akaszynski @germa89 - we would need to create a release for this so that the wheels are uploaded and solve the issues mentioned on #146

@akaszynski
Copy link
Collaborator

@RobPasMue, recommend we use cibuildwheel. See pyvista/pymeshfix#44

Copy link
Collaborator

@akaszynski akaszynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM.

@akaszynski akaszynski merged commit 819de66 into main Aug 4, 2022
@akaszynski akaszynski deleted the feat/support-macos branch August 4, 2022 03:55
@RobPasMue
Copy link
Member Author

Thanks @akaszynski for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the build of macOS
2 participants