Create metapackage #35

RobPasMue · 2022-07-29T14:19:43Z

Resolving #34 #13

RobPasMue · 2022-07-29T14:20:31Z

Project adapted to pyproject.toml.
Working on setting up CI/CD now.

RobPasMue · 2022-08-01T12:19:07Z

Current situation:

I have cleaned up the repository in order to use a single pyproject.toml file with poetry (this allows us to remove the requirement files and lets dependabot update the reqs regularly)
We have created a "core" install and "extras" installs (for fluent-all, mapdl-all, all etc.)
Vale has been implemented as well for the docs (even though it's only the main README.rst and a simple index.rst)
Pre-commit implemented for style checks
A new versioning for this package has been conceived (YYYY.X.dev0 for main where YYYY is the release year and X is the release within the year)
A proper CI workflow has been implemented in which we are testing: code style, docs style, core build, "extras" build (nothing depends on it if it fails), packaging stage and release.

Future works:

It looks like Python 3.10 is failing due to VTK in some of our PyAnsys libraries. I will need to look into that before merging so that everything works. Probably will have to open PRs in those libraries where Python 3.10 is not supported.
We should also implement the automatic "milestone" generation. I already have some "local" proposal for this but I will have to handle it in a different PR (this one is already growing too much)

This being said, I'll leave this PR for review.

jorgepiloto

This looks really good, @RobPasMue. Just a couple of things:

No need to have a _version.py file. Let us have everything inside __init__.py. This allows also to simplify the very first lines in conf.py.
I agree on using poetry for this. It would be nice to commit the lock.file too.
Additionally to the wheel and source artifacts, we could ship the "wheelhouse", as PyMAPDL does, see these lines.

.github/workflows/ci-build.yml

Co-authored-by: Jorge Martínez <[email protected]>

RobPasMue · 2022-08-01T13:07:45Z

This looks really good, @RobPasMue. Just a couple of things:

No need to have a _version.py file. Let us have everything inside __init__.py. This allows also to simplify the very first lines in conf.py.

I agree on using poetry for this. It would be nice to commit the lock.file too.

Additionally to the wheel and source artifacts, we could ship the "wheelhouse", as PyMAPDL does, see these lines.

Thank you for your comments @jorgepiloto I fully agree with all of them. Let me change them :)

RobPasMue · 2022-08-01T16:14:52Z

Problems encountered with ansys-mapdl-reader and macOS for all Python versions. Pinging @akaszynski and @germa89 for discussion. It looks like (from the CI logs) that there are only ansys-mapdl-reader packages for macOS available up to 0.51.7... Kind of weird. I will look into it tomorrow.

Error message:

ERROR: Could not find a version that satisfies the requirement ansys-mapdl-reader==0.51.14; extra == "mapdl-all" or extra == "all" (from pyansys[mapdl-all]) (from versions: 0.50.0, 0.50.1, 0.50.2, 0.50.3, 0.50.4, 0.50.5, 0.50.6, 0.50.7, 0.50.8, 0.50.9, 0.50.10, 0.50.11, 0.50.12, 0.50.13, 0.50.14, 0.50.15, 0.50.16, 0.51.0, 0.51.1, 0.51.2, 0.51.3, 0.51.4, 0.51.5, 0.51.6, 0.51.7)
ERROR: No matching distribution found for ansys-mapdl-reader==0.51.14; extra == "mapdl-all" or extra == "all"

pyproject.toml

Co-authored-by: Maxime Rey <[email protected]>

pyproject.toml

akaszynski · 2022-08-04T05:19:59Z

pyproject.toml

+ansys-dpf-core = "==0.4.2"
+ansys-dpf-post = "==0.2.2"


These will have to be updated. As it stands, pydpf-core==0.5.0 is for 2022R2, which we're still waiting on.

At the moment, the latest available one is 0.4.2 (I refer to the released versions, not pre-released). As soon as they publish 0.5.0, dependabot will let us know

akaszynski · 2022-08-04T05:20:25Z

pyproject.toml

+
+# Optional dependencies
+ansys-mapdl-reader = {version = "==0.51.14", optional = true}
+# ansys-fluent-visualization = {version = "==0.4.0", optional = true}


We'll have to bring this up in a discussion tomorrow.

Agreed. Planning on. There is an issue open as well. ansys/pyfluent-visualization#94

pyproject.toml

Co-authored-by: Alex Kaszynski <[email protected]>

RobPasMue · 2022-08-04T07:47:28Z

@jorgepiloto @MaxJPRey @akaszynski I think, as it is, we can merge the PR. Can you please review it (and approve) when possible? Remaining open points already have issues created in this same repo

jorgepiloto · 2022-08-04T07:49:51Z

Sure, let me do a quick review on this, @RobPasMue 👍🏽

doc/source/conf.py

pyproject.toml

jorgepiloto

Just one change request regarding the conf.py file and a tiny comment. This looks really good. This solution is really smart, congratulations @RobPasMue 👏🏽

.github/workflows/ci-build.yml

MaxJPRey · 2022-08-04T09:41:10Z

Well done @RobPasMue. This is excellent.

Co-authored-by: Maxime Rey <[email protected]>

RobPasMue added 5 commits July 29, 2022 14:22

Mv PyAnsys folder to src/pyansys and remove build folder

a9ad52c

Adapt gitignore

c8a2621

Point docs to proper folder

17cb8d9

Adapt to pyproject.toml and create install configs

2ee426d

Import version in __init__ file

55c443c

RobPasMue self-assigned this Jul 29, 2022

This was linked to issues Jul 29, 2022

Create metapackage #34

Closed

Consider using pyproject.toml #13

Closed

RobPasMue added 9 commits July 29, 2022 16:45

"all" dependencies should be explicitly mentioned

d515f79

WIP on poetry

858b92d

Implementing pre-commit + cleaning reqs

6d14422

Add vale config

381c798

Removing reqs file

46c78cc

Updating vale accepted words

8f81a40

Creating an actual CI

0c5bceb

Update docs build stage

d948704

Change jobs description

d7bfc59

RobPasMue requested review from akaszynski and jorgepiloto August 1, 2022 12:11

RobPasMue requested a review from MaxJPRey August 1, 2022 12:19

RobPasMue marked this pull request as ready for review August 1, 2022 12:19

RobPasMue added this to the v2023R1 milestone Aug 1, 2022

jorgepiloto requested changes Aug 1, 2022

View reviewed changes

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved

Update .github/workflows/ci-build.yml

32e84fa

Co-authored-by: Jorge Martínez <[email protected]>

RobPasMue added 3 commits August 1, 2022 15:17

Removing _version and simplifying things

1344505

Remove unnecessary line

0162138

Simplifyinf conf.py

d7097d2

Remove pip upgrades - did not solve the problem

f1a1fdc

MaxJPRey reviewed Aug 1, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

MaxJPRey reviewed Aug 1, 2022

View reviewed changes

pyproject.toml Show resolved Hide resolved

Update pyproject.toml

17d3845

Co-authored-by: Maxime Rey <[email protected]>

akaszynski reviewed Aug 4, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

akaszynski reviewed Aug 4, 2022

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

akaszynski reviewed Aug 4, 2022

View reviewed changes

pyproject.toml Show resolved Hide resolved

akaszynski reviewed Aug 4, 2022

View reviewed changes

pyproject.toml Show resolved Hide resolved

Apply suggestions from code review by @akaszynski

499d8ab

Co-authored-by: Alex Kaszynski <[email protected]>

RobPasMue requested a review from jorgepiloto August 4, 2022 07:46

jorgepiloto reviewed Aug 4, 2022

View reviewed changes

doc/source/conf.py Outdated Show resolved Hide resolved

jorgepiloto reviewed Aug 4, 2022

View reviewed changes

pyproject.toml Show resolved Hide resolved

jorgepiloto requested changes Aug 4, 2022

View reviewed changes

RobPasMue added 2 commits August 4, 2022 10:19

Commiting @jorgepiloto's suggestion

64d2a3c

Pre-commit check

304df0f

RobPasMue requested a review from jorgepiloto August 4, 2022 08:31

jorgepiloto approved these changes Aug 4, 2022

View reviewed changes

MaxJPRey reviewed Aug 4, 2022

View reviewed changes

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved

MaxJPRey reviewed Aug 4, 2022

View reviewed changes

.github/workflows/ci-build.yml Outdated Show resolved Hide resolved

MaxJPRey reviewed Aug 4, 2022

View reviewed changes

.github/workflows/ci-build.yml Show resolved Hide resolved

MaxJPRey approved these changes Aug 4, 2022

View reviewed changes

Apply suggestions from code review

24241d4

Co-authored-by: Maxime Rey <[email protected]>

RobPasMue merged commit 54a8de5 into main Aug 4, 2022

RobPasMue deleted the feat/create-metapackage branch August 4, 2022 09:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create metapackage #35

Create metapackage #35

RobPasMue commented Jul 29, 2022

RobPasMue commented Jul 29, 2022

RobPasMue commented Aug 1, 2022 •

edited

Loading

jorgepiloto left a comment

RobPasMue commented Aug 1, 2022

RobPasMue commented Aug 1, 2022 •

edited

Loading

akaszynski Aug 4, 2022

RobPasMue Aug 4, 2022 •

edited

Loading

akaszynski Aug 4, 2022

RobPasMue Aug 4, 2022

RobPasMue commented Aug 4, 2022

jorgepiloto commented Aug 4, 2022

jorgepiloto left a comment

MaxJPRey commented Aug 4, 2022

		ansys-dpf-core = "==0.4.2"
		ansys-dpf-post = "==0.2.2"

Create metapackage #35

Create metapackage #35

Conversation

RobPasMue commented Jul 29, 2022

RobPasMue commented Jul 29, 2022

RobPasMue commented Aug 1, 2022 • edited Loading

jorgepiloto left a comment

Choose a reason for hiding this comment

RobPasMue commented Aug 1, 2022

RobPasMue commented Aug 1, 2022 • edited Loading

akaszynski Aug 4, 2022

Choose a reason for hiding this comment

RobPasMue Aug 4, 2022 • edited Loading

Choose a reason for hiding this comment

akaszynski Aug 4, 2022

Choose a reason for hiding this comment

RobPasMue Aug 4, 2022

Choose a reason for hiding this comment

RobPasMue commented Aug 4, 2022

jorgepiloto commented Aug 4, 2022

jorgepiloto left a comment

Choose a reason for hiding this comment

MaxJPRey commented Aug 4, 2022

RobPasMue commented Aug 1, 2022 •

edited

Loading

RobPasMue commented Aug 1, 2022 •

edited

Loading

RobPasMue Aug 4, 2022 •

edited

Loading