Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: generic.py restructuring #2649

Merged
merged 16 commits into from
Apr 8, 2024
Merged

refactor: generic.py restructuring #2649

merged 16 commits into from
Apr 8, 2024

Conversation

hpohekar
Copy link
Collaborator

@hpohekar hpohekar commented Apr 3, 2024 •
edited
Loading

closes #2643

  1. Removed generic.py as it's name was not helping to clarify it's usage.
  2. in_notebook moved to check_in_notebook.py
  3. loop related functions moved to event_loop.py.
  4. Singleton metaclasses moved to singlton_meta.py
  5. timing moved to timing_decorator.py

@hpohekar
Copy link
Collaborator Author

hpohekar commented Apr 3, 2024

@seanpearsonuk @mkundu1 @prmukherj

We can rename recently added modules. Please share if you have any suggestions. Thank you.

mkundu1
mkundu1 approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@mkundu1 mkundu1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we move those singular functions within a module to an __init__.py in the parent module? We won't loose anything in terms of namespaces if we do that.

@hpohekar hpohekar merged commit acc73a9 into main Apr 8, 2024
26 checks passed
@hpohekar hpohekar deleted the fix/generic_restructuring branch April 8, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PipKat PipKat PipKat left review comments

@prmukherj prmukherj prmukherj approved these changes

@mkundu1 mkundu1 mkundu1 approved these changes

@seanpearsonuk seanpearsonuk seanpearsonuk approved these changes

@ajain-work ajain-work Awaiting requested review from ajain-work

@dnwillia-work dnwillia-work Awaiting requested review from dnwillia-work

@h-krishnan h-krishnan Awaiting requested review from h-krishnan

@raph-luc raph-luc Awaiting requested review from raph-luc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

utils/generic.py: confusing mix of functionality
5 participants
@hpohekar @PipKat @seanpearsonuk @mkundu1 @prmukherj