Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utils/generic.py: confusing mix of functionality #2643

Closed
seanpearsonuk opened this issue Apr 2, 2024 · 2 comments · Fixed by #2649
Closed

utils/generic.py: confusing mix of functionality #2643

seanpearsonuk opened this issue Apr 2, 2024 · 2 comments · Fixed by #2649
Assignees

Comments

@seanpearsonuk
Copy link
Collaborator

seanpearsonuk commented Apr 2, 2024

  • contains unrelated functionalities
  • each group of functionality should be in a separate module with a relevant name
  • loop is a shared object instantiated at module scope, only relevant to some functions
  • utils namespace name is not helpful. Are all these things meant to be public?
@hpohekar
Copy link
Collaborator

hpohekar commented Apr 3, 2024

@seanpearsonuk

Regarding Are all these things meant to be public? - We are not including these modules in rst. Therefore they are not available in public documentation. If we want, we can make them private explicitly.

@hpohekar
Copy link
Collaborator

hpohekar commented Apr 3, 2024

@seanpearsonuk

Regarding utils namespace name is not helpful. - Do we want to rename it to something like utilities ?

@github-project-automation github-project-automation bot moved this from Prioritised to In progress in PyFluent Public Roadmap Apr 8, 2024
@seanpearsonuk seanpearsonuk moved this from In progress to Done in PyFluent Public Roadmap Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 2021-2024
Development

Successfully merging a pull request may close this issue.

3 participants