Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update minimum required BoM Analytics Services version #670

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

Andy-Grigg
Copy link
Collaborator

@Andy-Grigg Andy-Grigg commented Dec 16, 2024

Update the advertised minimum BoM Analytics Services version provided in an error message if the services cannot be found.

Also update the error message and constant, to reflect that we are referring to the BAS version, as opposed to the Granta MI version.

This fix should be cherry-picked onto the release/2.2 and release/2.1 branches following merge.

@github-actions github-actions bot added the bug Something isn't working label Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (564cd6d) to head (018f3b7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #670   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          18       18           
  Lines        2533     2533           
=======================================
  Hits         2473     2473           
  Misses         60       60           
Flag Coverage Δ
integration 83.10% <100.00%> (ø)
unittests 97.19% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andy-Grigg Andy-Grigg added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 9784768 Dec 16, 2024
44 checks passed
@Andy-Grigg Andy-Grigg deleted the fix/fix-version-error branch December 16, 2024 14:34
Andy-Grigg added a commit that referenced this pull request Dec 16, 2024
Andy-Grigg added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants