Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BoM Analytics Services dependency #669

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

Andy-Grigg
Copy link
Collaborator

Update the BoM Analytics Services dependency to 2024 R2, which is required because of #465.

Also clarify the source of the dependency in the metapackage instructions, as being dependent on BAS, as opposed to Granta MI itself.

This fix should be cherry-picked onto the release/2.2 and release/2.1 branches following merge.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.63%. Comparing base (564cd6d) to head (8b437f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #669   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files          18       18           
  Lines        2533     2533           
=======================================
  Hits         2473     2473           
  Misses         60       60           
Flag Coverage Δ
integration 83.10% <ø> (ø)
unittests 97.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ludovicsteinbach ludovicsteinbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the run-time check version also be 24R2?

@Andy-Grigg
Copy link
Collaborator Author

Should the run-time check version also be 24R2?

Addressed in #670

@Andy-Grigg Andy-Grigg added this pull request to the merge queue Dec 16, 2024
Merged via the queue into main with commit 48ac496 Dec 16, 2024
44 checks passed
@Andy-Grigg Andy-Grigg deleted the doc/improve-bas-dependency branch December 16, 2024 14:34
Andy-Grigg added a commit that referenced this pull request Dec 16, 2024
Andy-Grigg added a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants