-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test setup, update dependencies #137
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
dependencies
Related with project dependencies
maintenance
Package and maintenance related
labels
Dec 2, 2024
greschd
force-pushed
the
maint/update_dependencies
branch
from
December 2, 2024 13:44
d2734db
to
5a96683
Compare
greschd
force-pushed
the
maint/update_dependencies
branch
from
December 2, 2024 13:48
bddecb5
to
b0cac16
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #137 +/- ##
=======================================
Coverage 89.77% 89.77%
=======================================
Files 3 3
Lines 88 88
=======================================
Hits 79 79
Misses 9 9 ☔ View full report in Codecov by Sentry. |
…ansys-tools-filetransfer into maint/update_dependencies
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix test setup on Linux by introducing a small
sleep
after launching the server. The reason why this is needed is not completely clear, I suspect a problem with binding to the port. In PyACP tests (which launch viadocker compose
), we've never seen this problem.Improve the error handling in the helper context managers of the tests.
Update the poetry lockfile.