Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test setup, update dependencies #137

Merged
merged 8 commits into from
Dec 2, 2024
Merged

Conversation

greschd
Copy link
Member

@greschd greschd commented Dec 2, 2024

Fix test setup on Linux by introducing a small sleep after launching the server. The reason why this is needed is not completely clear, I suspect a problem with binding to the port. In PyACP tests (which launch via docker compose), we've never seen this problem.

Improve the error handling in the helper context managers of the tests.

Update the poetry lockfile.

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Dec 2, 2024
@greschd greschd force-pushed the maint/update_dependencies branch from d2734db to 5a96683 Compare December 2, 2024 13:44
@greschd greschd force-pushed the maint/update_dependencies branch from bddecb5 to b0cac16 Compare December 2, 2024 13:48
@greschd greschd changed the title Update lockfile Fix test setup, update dependencies Dec 2, 2024
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.77%. Comparing base (cbbc691) to head (ed04ac8).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   89.77%   89.77%           
=======================================
  Files           3        3           
  Lines          88       88           
=======================================
  Hits           79       79           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greschd greschd enabled auto-merge (squash) December 2, 2024 14:30
@greschd greschd merged commit bd355fc into main Dec 2, 2024
29 checks passed
@greschd greschd deleted the maint/update_dependencies branch December 2, 2024 14:31
@greschd greschd mentioned this pull request Dec 2, 2024
greschd added a commit that referenced this pull request Dec 2, 2024
Accidentally added in #137.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Related with project dependencies maintenance Package and maintenance related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants