Skip to content

Commit

Permalink
Fix test setup, update dependencies (#137)
Browse files Browse the repository at this point in the history
Fix test setup on Linux by introducing a small `sleep` after launching the server. The reason why this is needed is not completely clear, I suspect a problem with binding to the port. In PyACP tests (which launch via `docker compose`), we've never seen this problem.

Improve the error handling in the helper context managers of the tests.

Update the poetry lockfile and pre-commit hooks.
  • Loading branch information
greschd authored Dec 2, 2024
1 parent cbbc691 commit bd355fc
Show file tree
Hide file tree
Showing 6 changed files with 672 additions and 593 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/ci_cd.yml
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,10 @@ jobs:
- name: Pull server docker image
run: |
docker pull ghcr.io/ansys/tools-filetransfer:latest
- name: DEBUG STEP
run: |
docker run --detach --name tools-filetransfer ghcr.io/ansys/tools-filetransfer:latest
docker ps -a
- name: Test with tox
# Only the tox environment specified in the tox.ini gh-actions is run
run: |
Expand Down
12 changes: 6 additions & 6 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
repos:

- repo: https://github.com/asottile/pyupgrade
rev: v3.15.0
rev: v3.19.0
hooks:
- id: pyupgrade
args: [--py39-plus]

- repo: https://github.com/psf/black
rev: 24.2.0
rev: 24.10.0
hooks:
- id: black

Expand All @@ -17,15 +17,15 @@ repos:
- id: isort

- repo: https://github.com/pycqa/flake8
rev: 7.0.0
rev: 7.1.1
hooks:
- id: flake8

- repo: https://github.com/codespell-project/codespell
rev: v2.2.6
rev: v2.3.0
hooks:
- id: codespell
exclude: "^(poetry\\.lock)|(CONTRIBUTORS\\.md)$"
exclude: "^(pyproject\\.toml)|(poetry\\.lock)|(CONTRIBUTORS\\.md)|(CODE_OF_CONDUCT\\.md)$"

- repo: https://github.com/pycqa/pydocstyle
rev: 6.3.0
Expand All @@ -35,7 +35,7 @@ repos:
exclude: "tests/"

- repo: https://github.com/ansys/pre-commit-hooks
rev: v0.2.8
rev: v0.4.4
hooks:
- id: add-license-headers
args: ["--start_year", "2022"]
Expand Down
14 changes: 7 additions & 7 deletions LICENSE
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
MIT License

Copyright (c) 2022 - 2024 ANSYS, Inc. All rights reserved.
Copyright (c) 2022 - 2024 ANSYS, Inc. and/or its affiliates.

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
of the Software, and to permit persons to whom the Software is furnished to do
so, subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.
Expand Down
1 change: 1 addition & 0 deletions doc/changelog.d/137.dependencies.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix test setup, update dependencies
Loading

0 comments on commit bd355fc

Please sign in to comment.